From: Tom Lendacky <thomas.lendacky@amd.com>
To: David Miller <davem@davemloft.net>
Cc: <David.Laight@ACULAB.COM>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 06/10] amd-xgbe: Set DMA mask based on hardware register value
Date: Thu, 19 Mar 2015 13:53:26 -0500 [thread overview]
Message-ID: <550B1B26.8000204@amd.com> (raw)
In-Reply-To: <20150319.144324.217714702082923027.davem@davemloft.net>
On 03/19/2015 01:43 PM, David Miller wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
> Date: Thu, 19 Mar 2015 12:40:05 -0500
>
>> Except this version of the hardware can't return a 3
>
> Yep, I've never _ever_ seen HW return garbage in a register.
>
> Nope.
>
> No reason to every program defensively for that.
Point taken :-). I'll add a default to 32 bit and submit v2.
Thanks,
Tom
>
next prev parent reply other threads:[~2015-03-19 18:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 17:12 [PATCH net-next 00/10] amd-xgbe: AMD XGBE driver updates 2015-03-19 Tom Lendacky
2015-03-19 17:12 ` [PATCH net-next 01/10] amd-xgbe-phy: Use phydev advertising field vs supported Tom Lendacky
2015-03-19 17:12 ` [PATCH net-next 02/10] amd-xgbe-phy: Use the phy_driver flags field Tom Lendacky
2015-03-19 17:12 ` [PATCH net-next 03/10] amd-xgbe-phy: Provide support for auto-negotiation timeout Tom Lendacky
2015-03-19 17:12 ` [PATCH net-next 04/10] amd-xgbe: Clarify output message about queues Tom Lendacky
2015-03-19 17:12 ` [PATCH net-next 05/10] amd-xgbe: Use the new DMA memory barriers where appropriate Tom Lendacky
2015-03-19 17:13 ` [PATCH net-next 06/10] amd-xgbe: Set DMA mask based on hardware register value Tom Lendacky
2015-03-19 17:32 ` David Laight
2015-03-19 17:40 ` Tom Lendacky
2015-03-19 18:43 ` David Miller
2015-03-19 18:53 ` Tom Lendacky [this message]
2015-03-19 17:13 ` [PATCH net-next 07/10] amd-xgbe: Remove Tx coalescing Tom Lendacky
2015-03-19 17:13 ` [PATCH net-next 08/10] amd-xgbe: Fix Rx coalescing reporting Tom Lendacky
2015-03-19 17:13 ` [PATCH net-next 09/10] amd-xgbe: Use napi_alloc_skb when allocating skb in softirq Tom Lendacky
2015-03-19 17:13 ` [PATCH net-next 10/10] amd-xgbe: Rework the Rx path SKB allocation Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550B1B26.8000204@amd.com \
--to=thomas.lendacky@amd.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).