From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: richard.alpe@ericsson.com, jon.maloy@ericsson.com,
ying.xue@windriver.com, netdev@vger.kernel.org,
tipc-discussion@lists.sourceforge.net, erik.hugne@ericsson.com
Subject: Re: [PATCH] tipc: fix build issue when building without IPv6
Date: Thu, 19 Mar 2015 16:16:41 -0300 [thread overview]
Message-ID: <550B2099.50109@gmail.com> (raw)
In-Reply-To: <20150319.150433.850095478975909930.davem@davemloft.net>
On 19-03-2015 16:04, David Miller wrote:
> From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> Date: Thu, 19 Mar 2015 12:13:43 -0300
>
>> @@ -387,6 +391,11 @@ static int tipc_udp_enable(struct net *net, struct tipc_bearer *b,
>> tuncfg.encap_destroy = NULL;
>> setup_udp_tunnel_sock(net, ub->ubsock, &tuncfg);
>>
>> + /* At this point, IPv6 module should have been loaded in
>> + * udp_sock_create/sock_create_kern().
>> + */
>> + BUG_ON(!ipv6_stub);
>> +
>
> If IPV6=n this will be NULL no matter what.
>
> And if the module load gets an error, this will be NULL as well.
>
Oh indeed, and it (whatever check) should have been placed in a
ipv6-only path, like vxlan used to do.
Will fix, thanks.
Marcelo
next prev parent reply other threads:[~2015-03-19 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 15:13 [PATCH] tipc: fix build issue when building without IPv6 Marcelo Ricardo Leitner
2015-03-19 19:04 ` David Miller
2015-03-19 19:16 ` Marcelo Ricardo Leitner [this message]
2015-03-19 19:47 ` [PATCH v2] " Marcelo Ricardo Leitner
2015-03-19 20:06 ` David Miller
2015-03-20 2:09 ` Ying Xue
2015-03-20 12:35 ` Marcelo
2015-03-23 3:00 ` Ying Xue
2015-03-23 11:33 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550B2099.50109@gmail.com \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=richard.alpe@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).