From: Jonathan Toppins <jtoppins@cumulusnetworks.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Curt Brune <curt@cumulusnetworks.com>
Subject: Re: [PATCH v1 net-next] tuntap: convert to 64-bit interface statistics
Date: Thu, 19 Mar 2015 19:52:04 -0400 [thread overview]
Message-ID: <550B6124.7070001@cumulusnetworks.com> (raw)
In-Reply-To: <1426805764.25985.18.camel@edumazet-glaptop2.roam.corp.google.com>
On 3/19/15 6:56 PM, Eric Dumazet wrote:
> On Thu, 2015-03-19 at 17:56 -0400, Jonathan Toppins wrote:
>
>
>> Or are you suggesting per-cpu counters would be preferred which would
>> possibly eliminate the need for this lock?
>
> Might be overkill for a device that is probably used by one cpu,
> considering you defined a full struct rtnl_link_stats64, instead of the
> fields that are really handled.
>
Ok. So summarizing for v2, so far; eliminating the back-to-back lock ->
release -> lock -> release is preferred (I agree with this).
It still seems like you are not a huge fan of the additional lock,
should I hold off on sending v2 for a day, so we can ponder alternatives?
next prev parent reply other threads:[~2015-03-19 23:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 19:51 [PATCH v1 net-next] tuntap: convert to 64-bit interface statistics Jonathan Toppins
2015-03-19 21:38 ` Eric Dumazet
2015-03-19 21:50 ` Jonathan Toppins
2015-03-19 21:56 ` Jonathan Toppins
2015-03-19 22:56 ` Eric Dumazet
2015-03-19 23:52 ` Jonathan Toppins [this message]
2015-03-20 1:04 ` Eric Dumazet
2015-03-19 23:57 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550B6124.7070001@cumulusnetworks.com \
--to=jtoppins@cumulusnetworks.com \
--cc=curt@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).