* [PATCH 11/13] can: at91_can: use endian agnostic IO accessors [not found] <1426693992-31163-1-git-send-email-ben.dooks@codethink.co.uk> @ 2015-03-18 15:53 ` Ben Dooks 2015-03-19 16:47 ` Nicolas Ferre 2015-03-20 9:06 ` Marc Kleine-Budde 0 siblings, 2 replies; 3+ messages in thread From: Ben Dooks @ 2015-03-18 15:53 UTC (permalink / raw) To: linux-kernel, linux-arm-kernel Cc: Ben Dooks, Wolfgang Grandegger, Marc Kleine-Budde, linux-can, netdev, Nicolas Ferre Change __raw accesors to endian agnostic versions to allow the driver to work properly on big endian systems. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> -- CC: Wolfgang Grandegger <wg@grandegger.com> CC: Marc Kleine-Budde <mkl@pengutronix.de> CC: linux-can@vger.kernel.org CC: netdev@vger.kernel.org CC: Nicolas Ferre <nicolas.ferre@atmel.com> --- drivers/net/can/at91_can.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c index eeb4b8b..f4e40aa 100644 --- a/drivers/net/can/at91_can.c +++ b/drivers/net/can/at91_can.c @@ -291,13 +291,13 @@ static inline unsigned int get_tx_echo_mb(const struct at91_priv *priv) static inline u32 at91_read(const struct at91_priv *priv, enum at91_reg reg) { - return __raw_readl(priv->reg_base + reg); + return readl_relaxed(priv->reg_base + reg); } static inline void at91_write(const struct at91_priv *priv, enum at91_reg reg, u32 value) { - __raw_writel(value, priv->reg_base + reg); + writel_relaxed(value, priv->reg_base + reg); } static inline void set_mb_mode_prio(const struct at91_priv *priv, -- 2.1.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 11/13] can: at91_can: use endian agnostic IO accessors 2015-03-18 15:53 ` [PATCH 11/13] can: at91_can: use endian agnostic IO accessors Ben Dooks @ 2015-03-19 16:47 ` Nicolas Ferre 2015-03-20 9:06 ` Marc Kleine-Budde 1 sibling, 0 replies; 3+ messages in thread From: Nicolas Ferre @ 2015-03-19 16:47 UTC (permalink / raw) To: Ben Dooks, Marc Kleine-Budde, linux-can Cc: linux-kernel, linux-arm-kernel, Wolfgang Grandegger, netdev Le 18/03/2015 16:53, Ben Dooks a écrit : > Change __raw accesors to endian agnostic versions to allow the driver > to work properly on big endian systems. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > -- > CC: Wolfgang Grandegger <wg@grandegger.com> > CC: Marc Kleine-Budde <mkl@pengutronix.de> > CC: linux-can@vger.kernel.org > CC: netdev@vger.kernel.org > CC: Nicolas Ferre <nicolas.ferre@atmel.com> Sure! Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Thanks, bye. > --- > drivers/net/can/at91_can.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c > index eeb4b8b..f4e40aa 100644 > --- a/drivers/net/can/at91_can.c > +++ b/drivers/net/can/at91_can.c > @@ -291,13 +291,13 @@ static inline unsigned int get_tx_echo_mb(const struct at91_priv *priv) > > static inline u32 at91_read(const struct at91_priv *priv, enum at91_reg reg) > { > - return __raw_readl(priv->reg_base + reg); > + return readl_relaxed(priv->reg_base + reg); > } > > static inline void at91_write(const struct at91_priv *priv, enum at91_reg reg, > u32 value) > { > - __raw_writel(value, priv->reg_base + reg); > + writel_relaxed(value, priv->reg_base + reg); > } > > static inline void set_mb_mode_prio(const struct at91_priv *priv, > -- Nicolas Ferre ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 11/13] can: at91_can: use endian agnostic IO accessors 2015-03-18 15:53 ` [PATCH 11/13] can: at91_can: use endian agnostic IO accessors Ben Dooks 2015-03-19 16:47 ` Nicolas Ferre @ 2015-03-20 9:06 ` Marc Kleine-Budde 1 sibling, 0 replies; 3+ messages in thread From: Marc Kleine-Budde @ 2015-03-20 9:06 UTC (permalink / raw) To: Ben Dooks, linux-kernel, linux-arm-kernel Cc: Wolfgang Grandegger, linux-can, netdev, Nicolas Ferre [-- Attachment #1: Type: text/plain, Size: 539 bytes --] On 03/18/2015 04:53 PM, Ben Dooks wrote: > Change __raw accesors to endian agnostic versions to allow the driver > to work properly on big endian systems. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> applied to can-next. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-20 9:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1426693992-31163-1-git-send-email-ben.dooks@codethink.co.uk>
2015-03-18 15:53 ` [PATCH 11/13] can: at91_can: use endian agnostic IO accessors Ben Dooks
2015-03-19 16:47 ` Nicolas Ferre
2015-03-20 9:06 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).