From: Alexei Starovoitov <ast@plumgrid.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Jiri Olsa <jolsa@redhat.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
"David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-api@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk()
Date: Fri, 20 Mar 2015 14:44:21 -0700 [thread overview]
Message-ID: <550C94B5.80301@plumgrid.com> (raw)
In-Reply-To: <20150320172219.45ff7157@gandalf.local.home>
On 3/20/15 2:22 PM, Steven Rostedt wrote:
>> +/* limited trace_printk()
>> + * only %d %u %x %ld %lu %lx %lld %llu %llx %p conversion specifiers allowed
>> + */
>
> Ah! Again, don't contaminate the rest of the kernel with net comment
> styles! :-)
ok :)
>> + } else if (fmt[i] == 'p') {
>> + mod[fmt_cnt]++;
>> + i++;
>> + if (!isspace(fmt[i]) && fmt[i] != 0)
>
> I wonder if we should allow punctuation here too? None alpha-numeric
> characters?
yes. just checked all of ispunct characters after %p.
All should be fine.
Thanks!
next prev parent reply other threads:[~2015-03-20 21:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 1:59 [PATCH v8 tip 0/9] tracing: attach eBPF programs to kprobes Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 1/9] bpf: make internal bpf API independent of CONFIG_BPF_SYSCALL ifdefs Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 3/9] tracing: attach BPF programs to kprobes Alexei Starovoitov
2015-03-20 21:09 ` Steven Rostedt
[not found] ` <20150320170907.388d8c33-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2015-03-20 21:38 ` Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 4/9] tracing: allow BPF programs to call bpf_ktime_get_ns() Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk() Alexei Starovoitov
2015-03-20 21:22 ` Steven Rostedt
2015-03-20 21:44 ` Alexei Starovoitov [this message]
2015-03-20 1:59 ` [PATCH v8 tip 6/9] samples: bpf: simple non-portable kprobe filter example Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 7/9] samples: bpf: counting example for kfree_skb and write syscall Alexei Starovoitov
[not found] ` <1426816787-5001-1-git-send-email-ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-03-20 1:59 ` [PATCH v8 tip 2/9] tracing: add kprobe flag Alexei Starovoitov
2015-03-20 20:11 ` Steven Rostedt
2015-03-20 1:59 ` [PATCH v8 tip 8/9] samples: bpf: IO latency analysis (iosnoop/heatmap) Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 9/9] samples: bpf: kmem_alloc/free tracker Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C94B5.80301@plumgrid.com \
--to=ast@plumgrid.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jolsa@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).