* [PATCH net-next] net: Move the comment about unsettable socket-level options to default clause and update its reference.
@ 2015-03-23 9:04 YOSHIFUJI Hideaki/吉藤英明
2015-03-23 20:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YOSHIFUJI Hideaki/吉藤英明 @ 2015-03-23 9:04 UTC (permalink / raw)
To: netdev, davem; +Cc: yoshfuji, hideaki.yoshifuji
We implement the SO_SNDLOWAT etc not to be settable and return
ENOPROTOOPT per 1003.1g 7. Move the comment to appropriate
position and update the reference.
Signed-off-by: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
---
net/core/sock.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/core/sock.c b/net/core/sock.c
index d9f9e48..01a4ebb 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -928,8 +928,6 @@ set_rcvbuf:
sk->sk_mark = val;
break;
- /* We implement the SO_SNDLOWAT etc to
- not be settable (1003.1g 5.3) */
case SO_RXQ_OVFL:
sock_valbool_flag(sk, SOCK_RXQ_OVFL, valbool);
break;
@@ -1234,6 +1232,9 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
break;
default:
+ /* We implement the SO_SNDLOWAT etc to not be settable
+ * (1003.1g 7).
+ */
return -ENOPROTOOPT;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: Move the comment about unsettable socket-level options to default clause and update its reference.
2015-03-23 9:04 [PATCH net-next] net: Move the comment about unsettable socket-level options to default clause and update its reference YOSHIFUJI Hideaki/吉藤英明
@ 2015-03-23 20:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-03-23 20:55 UTC (permalink / raw)
To: hideaki.yoshifuji; +Cc: netdev, yoshfuji
From: YOSHIFUJI Hideaki/吉藤英明 <hideaki.yoshifuji@miraclelinux.com>
Date: Mon, 23 Mar 2015 18:04:13 +0900
> We implement the SO_SNDLOWAT etc not to be settable and return
> ENOPROTOOPT per 1003.1g 7. Move the comment to appropriate
> position and update the reference.
>
> Signed-off-by: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-23 20:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-23 9:04 [PATCH net-next] net: Move the comment about unsettable socket-level options to default clause and update its reference YOSHIFUJI Hideaki/吉藤英明
2015-03-23 20:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).