From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BB0CC43381 for ; Tue, 26 Mar 2019 02:44:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2AEC2080F for ; Tue, 26 Mar 2019 02:44:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fl9TRGHr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729993AbfCZCoj (ORCPT ); Mon, 25 Mar 2019 22:44:39 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:37478 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727492AbfCZCoj (ORCPT ); Mon, 25 Mar 2019 22:44:39 -0400 Received: by mail-pf1-f193.google.com with SMTP id 8so7366197pfr.4 for ; Mon, 25 Mar 2019 19:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wVhNPf1Xj+aIngRX26dhMYraX2FF0WvrE3a072YEL/I=; b=Fl9TRGHrVbx/wxCFbKLUTuRET+pqDaggFbParGx7/BqaC8yGzI+XIT7PARe9LgBBED H1mScNdEJS44AxpTQv0SKzf5PUvFE7HXwJyjAJ6d33uJGAwLzaYdR1xpLxzj3fxp52fT 1gtfEjpYZmH/XIoKFbgnn9gsWR6/UEUdfPcbEU5FpIrPZ93RjIu4zpBhUJAXa4O3sp2+ V6d1IzsHcOLl3evk/PrQxs3gubnpFvsSq9+dbaGWrIOsZJgitnHNfzpfLWcgpow2IV0R LIpXqCO+4eGo7KCL6me2b4DueEsNNh6WQdK6aZo/SQXmAWLJ8Lmh2y3V+U02G86bZZr8 Lo8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wVhNPf1Xj+aIngRX26dhMYraX2FF0WvrE3a072YEL/I=; b=TPFikgy8tnTeVXOCY9gUFT9JnpbzGUJF7fBytXoWe5Ezy83utMC+uaJr3sTCdw84tC 19yJOebhXRTjPbdL71liy4NHtiUaL6+baPSIUO/5vm8cwTCEn2HG2yNZf4lsFbgQwE6K 9ybYQDCyiTJ8w4YLylj7kUsgmHPIjbFQOj7iG85mmaegvDvqdc4fpPtYeyccWlhkGR79 Mc1kDdNmzw+CAw/vi3RVQzRthqm+pT1ku3jcqD/Yn7JxyJI8t3MPwGSdNw3f16/G2mUf w/dVUvgAXm2orwpPJl2Gm1bHOQKKTYJCwMe3pMIee7A+dczMelYi8bvWMWlld+k8MQvx DeEw== X-Gm-Message-State: APjAAAUIGW2zifRlgvWv+ffZEMWW0LRWh94m1koi2+f3pxsxcIX7Hoxf 37KBQBTUpZmejE5I2crQCxE= X-Google-Smtp-Source: APXvYqy2jUqovPcQkkgMcr8hpKY5f0bY6vX+PgXuUcF2Lz0JKR+5MuYvXlGs19JNKzEDY8/aSGi0Wg== X-Received: by 2002:a62:484:: with SMTP id 126mr27650990pfe.91.1553568278803; Mon, 25 Mar 2019 19:44:38 -0700 (PDT) Received: from [192.168.1.3] (ip68-101-123-102.oc.oc.cox.net. [68.101.123.102]) by smtp.gmail.com with ESMTPSA id j13sm22357509pfh.32.2019.03.25.19.44.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 19:44:38 -0700 (PDT) Subject: Re: [RFC PATCH net-next 09/13] net: dsa: sja1105: Add support for ethtool port counters To: Vladimir Oltean , davem@davemloft.net, netdev@vger.kernel.org Cc: andrew@lunn.ch, vivien.didelot@gmail.com, linus.walleij@linaro.org References: <20190324032346.32394-1-olteanv@gmail.com> <20190324032346.32394-10-olteanv@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: <550b2928-3c35-5e61-9d90-668a165da8ff@gmail.com> Date: Mon, 25 Mar 2019 19:44:37 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190324032346.32394-10-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > Signed-off-by: Vladimir Oltean > --- [snip] > + > +int sja1105_get_sset_count(struct dsa_switch *ds, int port, int sset) > +{ > + int count = ARRAY_SIZE(sja1105_port_stats); > + struct sja1105_private *priv = ds->priv; There is a missing if (sset != ETH_SS_STATS) return here potentially. With that: Reviewed-by: Florian Fainelli -- Florian