From: David Ahern <dsahern@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, jiri@resnulli.us, sfeldma@gmail.com
Subject: Re: [PATCH v4 1/3] net: add support for phys_port_name
Date: Tue, 24 Mar 2015 16:25:12 -0600 [thread overview]
Message-ID: <5511E448.8050809@gmail.com> (raw)
In-Reply-To: <20150324151318.4e50dcbb@urahara>
On 3/24/15 4:13 PM, Stephen Hemminger wrote:
> On Tue, 17 Mar 2015 20:23:15 -0600
> David Ahern <dsahern@gmail.com> wrote:
>
>> Similar to port id allow netdevices to specify port names and export
>> the name via sysfs. Drivers can implement the netdevice operation to
>> assist udev in having sane default names for the devices using the
>> rule:
>>
>> $ cat /etc/udev/rules.d/80-net-setup-link.rules
>> SUBSYSTEM=="net", ACTION=="add", ATTR{phys_port_name}!="",
>> NAME="$attr{phys_port_name}"
>>
>> Use of phys_name versus phys_id was suggested-by Jiri Pirko.
>>
>> Signed-off-by: David Ahern <dsahern@gmail.com>
>> Acked-by: Jiri Pirko <jiri@resnulli.us>
>> Acked-by: Scott Feldman <sfeldma@gmail.com>
>
> Should this also be settable as well?
>
>
The intention was for this to come from the device. Currently,
phys_port_id and phys_port_name only have get methods, so no set.
David
next prev parent reply other threads:[~2015-03-24 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 2:23 [PATCH v4 1/3] net: add support for phys_port_name David Ahern
2015-03-18 2:23 ` [PATCH v3 2/3] rocker: " David Ahern
2015-03-19 2:30 ` David Miller
2015-03-18 2:23 ` [PATCH 3/3] iproute2: Add " David Ahern
2015-03-19 2:30 ` [PATCH v4 1/3] net: add " David Miller
2015-03-24 22:13 ` Stephen Hemminger
2015-03-24 22:25 ` David Ahern [this message]
2015-03-25 6:37 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5511E448.8050809@gmail.com \
--to=dsahern@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).