From mboxrd@z Thu Jan 1 00:00:00 1970 From: yzhu1 Subject: Re: [PATCH for kernel 3.4.x 1/1] net: neighbour: Add mcast_resolicit to configure the number of multicast resolicitations in PROBE state Date: Wed, 25 Mar 2015 14:40:40 +0800 Message-ID: <55125868.9020902@windriver.com> References: <1427190355-1216-1-git-send-email-Yanjun.Zhu@windriver.com> <1427190355-1216-2-git-send-email-Yanjun.Zhu@windriver.com> <55113DFA.9080608@miraclelinux.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit To: YOSHIFUJI Hideaki , , , , , Return-path: Received: from mail.windriver.com ([147.11.1.11]:36749 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752273AbbCYGkn (ORCPT ); Wed, 25 Mar 2015 02:40:43 -0400 In-Reply-To: <55113DFA.9080608@miraclelinux.com> Sender: netdev-owner@vger.kernel.org List-ID: On 03/24/2015 06:35 PM, YOSHIFUJI Hideaki wrote: > Hi. > > Zhu Yanjun wrote: > >> We send unicast neighbor (ARP or NDP) solicitations ucast_probes >> times in PROBE state. Zhu Yanjun reported that some implementation >> does not reply against them and the entry will become FAILED, which >> is undesirable. >> >> We had been dealt with such nodes by sending multicast probes mcast_ >> solicit times after unicast probes in PROBE state. In 2003, I made > I? Or please Add the From: to change the author to me. > >> a change not to send them to improve compatibility with IPv6 NDP. >> >> Let's introduce per-protocol per-interface sysctl knob "mcast_ >> reprobe" to configure the number of multicast (re)solicitation for >> reconfirmation in PROBE state. The default is 0, since we have >> been doing so for 10+ years. >> > You should say: 'This patch is based on commit foobar ("title") by > author...' or something here. > >> Reported-by: Zhu Yanjun >> CC: Ulf Samuelsson >> Signed-off-by: YOSHIFUJI Hideaki >> Signed-off-by: YOSHIFUJI Hideaki >> [Zhu Yanjun: since kernel 3.4.x is different from mainline kernel(kernel 4.0-rcX). >> This patch is modified a lot.] >> Signed-off-by: Zhu Yanjun >> --- >> include/linux/neighbour.h | 1 + >> include/net/neighbour.h | 1 + >> net/core/neighbour.c | 20 +++++++++++++++++--- >> 3 files changed, 19 insertions(+), 3 deletions(-) >> >> diff --git a/include/linux/neighbour.h b/include/linux/neighbour.h >> index b188f68..6945f4f 100644 >> --- a/include/linux/neighbour.h >> +++ b/include/linux/neighbour.h >> @@ -112,6 +112,7 @@ enum { >> NDTPA_APP_PROBES, /* u32 */ >> NDTPA_UCAST_PROBES, /* u32 */ >> NDTPA_MCAST_PROBES, /* u32 */ >> + NDTPA_MCAST_REPROBES, /* u32 */ >> NDTPA_ANYCAST_DELAY, /* u64, msecs */ >> NDTPA_PROXY_DELAY, /* u64, msecs */ >> NDTPA_PROXY_QLEN, /* u32 */ > No, this breaks binary compatibility. Sorry. My bad. I will correct. Best Regards! Zhu Yanjun >