Re: [PATCH net-next v6 4/7] ixgbevf: Add a RETA query code

[Vlad Zolotarov <vladz@cloudius-systems.com>]

On 03/25/15 11:39, Jeff Kirsher wrote:
> On Wed, 2015-03-25 at 11:29 +0200, Vlad Zolotarov wrote:
>> On 03/25/15 00:50, Tantilov, Emil S wrote:
>>>> -----Original Message-----
>>>> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com]
>>>> Sent: Tuesday, March 24, 2015 11:41 AM
>>>> To: Tantilov, Emil S; netdev@vger.kernel.org
>>>> Cc: Kirsher, Jeffrey T; avi@cloudius-systems.com;
>> gleb@cloudius-systems.com
>>>> Subject: Re: [PATCH net-next v6 4/7] ixgbevf: Add a RETA query code
>>>>
>>>>
>>>>
>>>>> On 03/24/15 20:12, Tantilov, Emil S wrote:
>>>>> BTW - there are other issues with your patches. The indirection
>> table seems to come out as all 0s and the VF driver reports link
>> down/up when querying it.
>>>> Worked just fine to me on x540.
>>>> What is your setup? How did u check it? Did u remember to patch
>> "ip" tool and enable the querying?
>>> The issue with the link is that you do not have proper locking when
>> calling the mailbox which is messing up the link check subtask.
>> Basically you need to protect the calls to ixgbevf_get_rss_key and
>> get_reta with the mbx_lock similar to how the driver does it in all
>> cases where the mailbox is called.
>>
>> :D Just wrote u the same thing in a reply on your first email...
>> Sure. Let me fix it in v8.
> Since you will be producing a v8, can you please CC
> intel-wired-lan@lists.osuosl.org it is a mailing list we just created
> for all Linux kernel patches and kernel development for Intel wired
> Ethernet drivers.
>
> We also have a public patchworks project:
> http://patchwork.ozlabs.org/project/intel-wired-lan/list/
>
> I had planned on making an announcement on netdev later this week.

Sure thing, Jeff.