From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zolotarov Subject: Re: [PATCH net-next v6 4/7] ixgbevf: Add a RETA query code Date: Wed, 25 Mar 2015 11:41:29 +0200 Message-ID: <551282C9.8050800@cloudius-systems.com> References: <1427050887-19412-1-git-send-email-vladz@cloudius-systems.com> <1427050887-19412-5-git-send-email-vladz@cloudius-systems.com> <87618083B2453E4A8714035B62D6799250274730@FMSMSX105.amr.corp.intel.com> <55113B9B.3090308@cloudius-systems.com> <87618083B2453E4A8714035B62D6799250274C7F@FMSMSX105.amr.corp.intel.com> <5511AFD6.2020406@cloudius-systems.com> <87618083B2453E4A8714035B62D6799250274F2A@FMSMSX105.amr.corp.intel.com> <55127FE6.8030905@cloudius-systems.com> <1427276354.2601.49.camel@jtkirshe-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "Tantilov, Emil S" , "netdev@vger.kernel.org" , "avi@cloudius-systems.com" , "gleb@cloudius-systems.com" , "Skidmore, Donald C" To: Jeff Kirsher Return-path: Received: from mail-wi0-f177.google.com ([209.85.212.177]:34093 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055AbbCYJld (ORCPT ); Wed, 25 Mar 2015 05:41:33 -0400 Received: by wibg7 with SMTP id g7so69980184wib.1 for ; Wed, 25 Mar 2015 02:41:32 -0700 (PDT) In-Reply-To: <1427276354.2601.49.camel@jtkirshe-mobl> Sender: netdev-owner@vger.kernel.org List-ID: On 03/25/15 11:39, Jeff Kirsher wrote: > On Wed, 2015-03-25 at 11:29 +0200, Vlad Zolotarov wrote: >> On 03/25/15 00:50, Tantilov, Emil S wrote: >>>> -----Original Message----- >>>> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] >>>> Sent: Tuesday, March 24, 2015 11:41 AM >>>> To: Tantilov, Emil S; netdev@vger.kernel.org >>>> Cc: Kirsher, Jeffrey T; avi@cloudius-systems.com; >> gleb@cloudius-systems.com >>>> Subject: Re: [PATCH net-next v6 4/7] ixgbevf: Add a RETA query code >>>> >>>> >>>> >>>>> On 03/24/15 20:12, Tantilov, Emil S wrote: >>>>> BTW - there are other issues with your patches. The indirection >> table seems to come out as all 0s and the VF driver reports link >> down/up when querying it. >>>> Worked just fine to me on x540. >>>> What is your setup? How did u check it? Did u remember to patch >> "ip" tool and enable the querying? >>> The issue with the link is that you do not have proper locking when >> calling the mailbox which is messing up the link check subtask. >> Basically you need to protect the calls to ixgbevf_get_rss_key and >> get_reta with the mbx_lock similar to how the driver does it in all >> cases where the mailbox is called. >> >> :D Just wrote u the same thing in a reply on your first email... >> Sure. Let me fix it in v8. > Since you will be producing a v8, can you please CC > intel-wired-lan@lists.osuosl.org it is a mailing list we just created > for all Linux kernel patches and kernel development for Intel wired > Ethernet drivers. > > We also have a public patchworks project: > http://patchwork.ozlabs.org/project/intel-wired-lan/list/ > > I had planned on making an announcement on netdev later this week. Sure thing, Jeff.