From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] net: phy: realtek: fix RTL8201F sysfs name Date: Mon, 5 Nov 2018 18:24:08 -0800 Message-ID: <5512a79e-2c49-5360-274d-24c509ecd751@gmail.com> References: <20181104184346.GA27023@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Netdev , "David S. Miller" To: Andrew Lunn , =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= Return-path: Received: from mail-pl1-f195.google.com ([209.85.214.195]:37331 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726389AbeKFLrB (ORCPT ); Tue, 6 Nov 2018 06:47:01 -0500 Received: by mail-pl1-f195.google.com with SMTP id p6-v6so5399903pll.4 for ; Mon, 05 Nov 2018 18:24:13 -0800 (PST) In-Reply-To: <20181104184346.GA27023@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/4/2018 10:43 AM, Andrew Lunn wrote: > On Sun, Nov 04, 2018 at 07:02:42PM +0100, Holger Hoffstätte wrote: >> Since 4.19 the following error in sysfs has appeared when using the >> r8169 NIC driver: >> >> $cd /sys/module/realtek/drivers >> $ls -l >> ls: cannot access 'mdio_bus:RTL8201F 10/100Mbps Ethernet': No such file or directory >> [..garbled dir entries follow..] >> >> Apparently the forward slash in "10/100Mbps Ethernet" is interpreted >> as directory separator that leads nowhere, and was introduced in commit >> 513588dd44b ("net: phy: realtek: add RTL8201F phy-id and functions"). >> >> Fix this by removing the offending slash in the driver name. >> >> Other drivers in net/phy seem to have the same problem, but I cannot >> test/verify them. >> >> Signed-off-by: Holger Hoffstätte > > Fixes:513588dd44b ("net: phy: realtek: add RTL8201F phy-id and functions"). > > Reviewed-by: Andrew Lunn > > David, please apply to net. We should probably seek a more generic solution within sysfs to deny specific problematic characters from being used, such as ., .., / etc. -- Florian