From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Alexey Kodanev <alexey.kodanev@oracle.com>, netdev@vger.kernel.org
Cc: vasily.isaenko@oracle.com
Subject: Re: [PATCH v2] net: tcp6: fix double call of tcp_v6_fill_cb()
Date: Thu, 26 Mar 2015 17:08:05 +0300 [thread overview]
Message-ID: <551412C5.3050804@cogentembedded.com> (raw)
In-Reply-To: <1427358484-16402-1-git-send-email-alexey.kodanev@oracle.com>
Hello.
On 3/26/2015 11:28 AM, Alexey Kodanev wrote:
> Regression from the following commit: 2dc49d1680.
Please also specify that commit's summary line in parens.
> tcp_v6_fill_cb() will be called twice if socket's state changes from
> TCP_TIME_WAIT to TCP_LISTEN. That can result in control buffer data
> corruption because in the second tcp_v6_fill_cb() call it's not copying
> IP6CB(skb) anymore, but 'seq', 'end_seq', etc., so we can get weird and
> unpredictable results. Performance loss of up to 1200% has been observed
> in LTP/vxlan03 test.
> This can be fixed by copying inet6_skb_parm to the beginning of 'cb'
> only if xfrm6_policy_check() and tcp_v6_fill_cb() are going to be
> called again.
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
[...]
WBR, Sergei
prev parent reply other threads:[~2015-03-26 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 8:28 [PATCH v2] net: tcp6: fix double call of tcp_v6_fill_cb() Alexey Kodanev
2015-03-26 11:46 ` Eric Dumazet
2015-03-26 14:08 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551412C5.3050804@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=alexey.kodanev@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).