From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Cc: netdev@vger.kernel.org, sergei.shtylyov@cogentembedded.com
Subject: Re: [RFC PATCH v3 1/2] can: fix multiple delivery of a single CAN frame for overlapping CAN filters
Date: Wed, 01 Apr 2015 11:44:17 +0200 [thread overview]
Message-ID: <551BBDF1.6070208@hartkopp.net> (raw)
In-Reply-To: <551BB555.7030808@pengutronix.de>
Hi Marc,
On 01.04.2015 11:07, Marc Kleine-Budde wrote:
> On 04/01/2015 07:50 AM, Oliver Hartkopp wrote:
>> +struct uniqframe {
>> + const struct sk_buff *skb;
>> + ktime_t tstamp;
>> +};
>
> Nitpick: as ktime_t is always a 64 bit value, I think putting it first
> might provide better alignment.
No objections. Good idea.
>
> No need to repost, I'll change this while applying, if you're okay with
> this.
I would suggest to take both patches into can-next (for 4.1).
Even though I did some testing on my i7 machine I would like this per-CPU
stuff to come to maturity with some more testing of other users.
IMO the patch 1/2 (aka 'the fix') is not critical - at least it was not for
the last 10 years :-)
So if $COSTUMER really needs this functionality it should be no problem to
apply these really short and clear patches.
Best regards,
Oliver
next prev parent reply other threads:[~2015-04-01 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 5:50 [RFC PATCH v3 0/2] can: join filters with per-CPU variables Oliver Hartkopp
2015-04-01 5:50 ` [RFC PATCH v3 1/2] can: fix multiple delivery of a single CAN frame for overlapping CAN filters Oliver Hartkopp
2015-04-01 9:07 ` Marc Kleine-Budde
2015-04-01 9:44 ` Oliver Hartkopp [this message]
2015-04-01 9:46 ` Marc Kleine-Budde
2015-04-01 5:50 ` [RFC PATCH v3 2/2] can: introduce new raw socket option to join the given " Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551BBDF1.6070208@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).