From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] sh_eth: move inline functions to the header file
Date: Tue, 07 Apr 2015 20:21:23 +0300 [thread overview]
Message-ID: <55241213.50200@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdWS05eOT11prYaVddGwUjGCEDHfd=kn7JYv73HKw0s2BQ@mail.gmail.com>
Hello.
On 04/07/2015 04:21 PM, Geert Uytterhoeven wrote:
>> The explicitly inline functions belong to the header files, so move
>> cpu_to_edmac() and edmac_to_cpu() into the driver header.
> Why do they belong in the header file?
Because they're explicitly *inline*. The functions in the .c file
shouldn't have the *inline* keyword, DaveM wants us to rely on gcc's judgment.
> Are they (planned to be) used by
> another source file (EtherAVB?)?
No.
> Currently no other source file besides sh_eth.c includes sh_eth.h, so
> IMHO sh_eth.h could just be absorbed by sh_eth.c.
I agree, in principle.
[...]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Gr{oetje,eeting}s,
> Geert
WBR, Sergei
next prev parent reply other threads:[~2015-04-07 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 21:13 [PATCH] sh_eth: move inline functions to the header file Sergei Shtylyov
2015-04-07 13:21 ` Geert Uytterhoeven
2015-04-07 17:21 ` Sergei Shtylyov [this message]
2015-04-07 19:22 ` David Miller
2015-04-07 19:26 ` Sergei Shtylyov
2015-04-07 19:33 ` David Miller
2015-10-30 23:09 ` Sergei Shtylyov
2015-12-12 22:24 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55241213.50200@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=geert@linux-m68k.org \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).