From: Alexander Duyck <alexander.h.duyck@redhat.com>
To: Francois Romieu <romieu@fr.zoreil.com>, netdev@vger.kernel.org
Cc: Nix <nix@esperi.org.uk>, "David S. Miller" <davem@davemloft.net>,
rl@hellgate.ch, Bjarke Istrup Pedersen <gurligebis@gentoo.org>
Subject: Re: [PATCH net-next 1/4] via-rhine: commit receive buffer address before descriptor status update.
Date: Tue, 07 Apr 2015 12:54:18 -0700 [thread overview]
Message-ID: <552435EA.6010609@redhat.com> (raw)
In-Reply-To: <87c90b27962c818239073d3a65341054922bd563.1428340371.git.romieu@fr.zoreil.com>
On 04/06/2015 11:01 AM, Francois Romieu wrote:
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> ---
> drivers/net/ethernet/via/via-rhine.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c
> index a191afc..00fea3d 100644
> --- a/drivers/net/ethernet/via/via-rhine.c
> +++ b/drivers/net/ethernet/via/via-rhine.c
> @@ -2063,6 +2063,7 @@ static int rhine_rx(struct net_device *dev, int limit)
> break;
> }
> rp->rx_ring[entry].addr = cpu_to_le32(rp->rx_skbuff_dma[entry]);
> + wmb();
> }
> rp->rx_ring[entry].rx_status = cpu_to_le32(DescOwn);
> }
Do you need a full wmb() here or would a dma_wmb() be enough? It could
make a difference on some processor architectures.
- Alex
next prev parent reply other threads:[~2015-04-07 19:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 18:01 [PATCH RFT net-next 0/4] via-rhine receive buffers rework Francois Romieu
2015-04-06 18:01 ` [PATCH net-next 1/4] via-rhine: commit receive buffer address before descriptor status update Francois Romieu
2015-04-07 19:52 ` David Miller
2015-04-07 21:02 ` Francois Romieu
2015-04-07 21:19 ` Alexander Duyck
2015-04-07 21:27 ` David Miller
2015-04-07 21:54 ` Eric Dumazet
2015-04-07 22:12 ` Alexander Duyck
2015-04-07 22:22 ` Eric Dumazet
2015-04-07 23:20 ` Alexander Duyck
2015-04-08 11:40 ` David Laight
2015-04-07 19:54 ` Alexander Duyck [this message]
2015-04-06 18:01 ` [PATCH net-next 2/4] via-rhine: add allocation helpers Francois Romieu
2015-04-06 18:01 ` [PATCH net-next 3/4] via-rhine: gotoize rhine_open error path Francois Romieu
2015-04-06 18:01 ` [PATCH net-next 4/4] via-rhine: forbid holes in the receive descriptor ring Francois Romieu
2015-04-06 21:46 ` [PATCH RFT net-next 0/4] via-rhine receive buffers rework Nix
2015-04-07 10:46 ` Nix
2015-04-07 19:31 ` Francois Romieu
2015-04-07 19:41 ` Nix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552435EA.6010609@redhat.com \
--to=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=gurligebis@gentoo.org \
--cc=netdev@vger.kernel.org \
--cc=nix@esperi.org.uk \
--cc=rl@hellgate.ch \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).