From mboxrd@z Thu Jan 1 00:00:00 1970 From: YOSHIFUJI Hideaki Subject: Re: [PATCH] iputils ping: add (non-raw) ICMP socket support Date: Wed, 08 Apr 2015 17:56:47 +0900 Message-ID: <5524ED4F.9070907@miraclelinux.com> References: <2142872.6QHf5ZAfZz@msg-id> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: hideaki.yoshifuji@miraclelinux.com, Vasiliy Kulikov , Tyler Hicks To: Salvatore Mesoraca , netdev@vger.kernel.org Return-path: Received: from exprod7og127.obsmtp.com ([64.18.2.210]:48086 "HELO exprod7og127.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751229AbbDHI4y (ORCPT ); Wed, 8 Apr 2015 04:56:54 -0400 Received: by mail-pd0-f170.google.com with SMTP id nk13so108515681pdb.0 for ; Wed, 08 Apr 2015 01:56:53 -0700 (PDT) In-Reply-To: <2142872.6QHf5ZAfZz@msg-id> Sender: netdev-owner@vger.kernel.org List-ID: Hi, Salvatore Mesoraca wrote: > From: Vasiliy Kulikov > > This patch adds non-raw IPPROTO_ICMP socket kind support that was added > to the Linux 3.0. The patch is backward-compatible: if ICMP socket kind > is not enabled in the kernel (either in case of an old kernel or > explicitly disabled via /proc/sys/net/ipv4/ping_group_range), ping uses > old privileged raw sockets as a fallback. : > This patch is going to be included in Ubuntu 15.10 and it is already > included in Gentoo stable tree (at the moment of the writing ping has > CAP_NET_RAW still enabled by default) it is also included in OpenWall > since 2011. > This patch also tries to sneak in a fix for a missing colon in a printf. > I've tested it on Linux 3.17.7 and it worked without issues. Please do not mix changes in a single commit. Thanks. -- Hideaki Yoshifuji Technical Division, MIRACLE LINUX CORPORATION