From: Larry Finger <Larry.Finger@lwfinger.net>
To: Cheolhyun Park <pch851130@gmail.com>,
chaoming_li@realsil.com.cn, kvalo@codeaurora.org,
linville@tuxdriver.com, Julia.Lawall@lip6.fr
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: misspelled code and comments corrected.
Date: Sun, 12 Apr 2015 11:26:10 -0500 [thread overview]
Message-ID: <552A9CA2.8080704@lwfinger.net> (raw)
In-Reply-To: <1428854665-5958-1-git-send-email-pch851130@gmail.com>
On 04/12/2015 11:04 AM, Cheolhyun Park wrote:
> Signed-off-by: Cheolhyun Park <pch851130@gmail.com>
When you send a corrected patch, it is common to indicate that this is a
corrected patch by putting the version number inside the [] in the subject, and
to indicate the changes inside the patch, but after the --- line. Neither of
these annotations will be included in the commit message, but they help the
maintainer keep track of the patch, and whether you have satisfied the
reviewer's comments. Thus this patch should have had the subject "[PATCH V2]
rtlwifi: ..." and you should have had the lines below after the ---:
> ---
V2 - Fixed the typo introduced in V1 as noted by Julia Lawall.
---
> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8821ae/dm.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> index f5ee67c..1273997 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> @@ -312,7 +312,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct ieee80211_hw *hw)
> struct dig_t *digtable = &rtlpriv->dm_digtable;
> u32 isbt;
>
> - /* modify DIG lower bound, deal with abnorally large false alarm */
> + /* modify DIG lower bound, deal with abnormally large false alarm */
> if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
> digtable->large_fa_hit++;
> if (digtable->forbidden_igi < digtable->cur_igvalue) {
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> index a1be5a6..f209cda 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> @@ -420,7 +420,7 @@ static void rtl92d_dm_dig(struct ieee80211_hw *hw)
> "dm_DIG() Before: Recover_cnt=%d, rx_gain_min=%x\n",
> de_digtable->recover_cnt, de_digtable->rx_gain_min);
>
> - /* deal with abnorally large false alarm */
> + /* deal with abnormally large false alarm */
> if (falsealm_cnt->cnt_all > 10000) {
> RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
> "dm_DIG(): Abnormally false alarm case\n");
> diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> index 0b2082d..342678d 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> @@ -873,7 +873,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
>
> if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
> RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
> - "Abnornally false alarm case.\n");
> + "Abnormally false alarm case.\n");
>
> if (dm_digtable->large_fa_hit != 3)
> dm_digtable->large_fa_hit++;
>
next prev parent reply other threads:[~2015-04-12 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 16:04 [PATCH] rtlwifi: misspelled code and comments corrected Cheolhyun Park
2015-04-12 16:26 ` Larry Finger [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-04-12 14:50 Cheolhyun Park
2015-04-12 15:56 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552A9CA2.8080704@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Julia.Lawall@lip6.fr \
--cc=chaoming_li@realsil.com.cn \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=pch851130@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).