netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Denys Vlasenko <dvlasenk@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Jan Engelhardt <jengelh@medozas.de>,
	Jiri Pirko <jpirko@redhat.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netns: deinline net_generic()
Date: Tue, 14 Apr 2015 17:04:41 +0200	[thread overview]
Message-ID: <552D2C89.6080601@redhat.com> (raw)
In-Reply-To: <1429021301.7346.29.camel@edumazet-glaptop2.roam.corp.google.com>

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

On 04/14/2015 04:21 PM, Eric Dumazet wrote:
> On Tue, 2015-04-14 at 15:57 +0200, Denys Vlasenko wrote:
> 
>> My allyesconfig, with BUG_ON's commented out:
>>
> 
> Right. But I can tell you nobody uses lockdep on a production kernel.
> 
> Here, at Google, we get what I described.

I'm trying to get to the .config which generates a small function.

So far, with LOCKDEP off, it is still this big:


net_generic:
        call    __fentry__
        pushq   %rbp    #
#APP
# 72 "./arch/x86/include/asm/preempt.h" 1
        incl %gs:__preempt_count(%rip)  # __preempt_count
# 0 "" 2
#NO_APP
        movq    %rsp, %rbp      #,
        pushq   %r12    #
        movq    %rdi, %r12      # net, net
        pushq   %rbx    #
        movl    %esi, %ebx      # id, id
        call    rcu_lock_acquire.constprop.15   #
        movq    4784(%r12), %rax        # MEM[(struct net_generic * const volatile *)net_2(D) + 4784B], _________p1
        decl    %ebx    # tmp65
        movslq  %ebx, %rbx      # tmp65, tmp66
        movq    24(%rax,%rbx,8), %rbx   # _________p1_4->ptr, ptr
        call    rcu_read_unlock #
        movq    %rbx, %rax      # ptr,
        popq    %rbx    #
        popq    %r12    #
        popq    %rbp    #
        ret


Config is attached.

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 44610 bytes --]

  reply	other threads:[~2015-04-14 15:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14 12:25 [PATCH] netns: deinline net_generic() Denys Vlasenko
2015-04-14 12:36 ` Jiri Pirko
2015-04-14 13:19 ` Eric Dumazet
2015-04-14 13:57   ` Denys Vlasenko
2015-04-14 14:21     ` Eric Dumazet
2015-04-14 15:04       ` Denys Vlasenko [this message]
2015-04-14 15:25         ` Eric Dumazet
2015-04-14 18:37 ` David Miller
2015-04-16 11:14   ` Denys Vlasenko
2015-04-16 12:38     ` Eric Dumazet
2015-04-17 17:05       ` Denys Vlasenko
2015-04-17 17:42         ` Eric Dumazet
2015-04-17 18:05           ` Denys Vlasenko
2015-04-17 18:55           ` David Miller
2015-04-17 19:55         ` David Miller
2015-04-16 15:41     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552D2C89.6080601@redhat.com \
    --to=dvlasenk@redhat.com \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jengelh@medozas.de \
    --cc=jpirko@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).