From: Guenter Roeck <linux@roeck-us.net>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state
Date: Thu, 16 Apr 2015 05:51:46 -0700 [thread overview]
Message-ID: <552FB062.5090307@roeck-us.net> (raw)
In-Reply-To: <20150416123742.GG13105@lunn.ch>
On 04/16/2015 05:37 AM, Andrew Lunn wrote:
> On Wed, Apr 15, 2015 at 10:12:42PM -0700, Guenter Roeck wrote:
>> Return correct error code if _mv88e6xxx_reg_read returns an error.
>>
>> Fixes: facd95b2e0ec0 ("net: dsa: mv88e6xxx: Add Hardware bridging support")
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Hi Guenter
>
> Good catch. I'm surprised there is no compiler warning, possibly used
> before set.
>
There was, actually. No idea how I missed that. Fengguang's build bots caught it.
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
Thanks!
Guenter
next prev parent reply other threads:[~2015-04-16 12:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 5:12 [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state Guenter Roeck
2015-04-16 12:37 ` Andrew Lunn
2015-04-16 12:51 ` Guenter Roeck [this message]
2015-04-16 13:46 ` Guenter Roeck
2015-04-16 18:51 ` Geert Uytterhoeven
2015-04-17 2:05 ` Guenter Roeck
2015-04-16 16:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552FB062.5090307@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).