From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Vecera Subject: Re: [PATCH net-next v2] be2net: log link status Date: Thu, 23 Apr 2015 08:52:03 +0200 Message-ID: <55389693.1050903@redhat.com> References: <1429710210-7291-1-git-send-email-ivecera@redhat.com> <447118c7-cb5e-4e64-88cc-8205cadfaf5e@CMEXHTCAS2.ad.emulex.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Subramanian Seetharaman , Ajit Kumar Khaparde , David Miller , Joe Perches To: Sathya Perla , "netdev@vger.kernel.org" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37464 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbbDWGwN (ORCPT ); Thu, 23 Apr 2015 02:52:13 -0400 In-Reply-To: <447118c7-cb5e-4e64-88cc-8205cadfaf5e@CMEXHTCAS2.ad.emulex.com> Sender: netdev-owner@vger.kernel.org List-ID: On 04/23/2015 08:31 AM, Sathya Perla wrote: >> -----Original Message----- >> From: Ivan Vecera [mailto:ivecera@redhat.com] >> >> The driver unlike other drivers does not log link state changes. >> >> v2: added current link speed to log message >> > Ivan, I disagree with the v2 change. I think your original intention > was just to log a message when the link goes up or down > asynchronously (i.e., without any user intervention.) > After alerting the user, if the user wants to know other link > properties like speed, duplex etc then the ethtool cmd needs > to be used; there is no need to log a message with those details. Yes, this was my original intention... to see these async link events in the system log. In this case the v1 should be used. Ivan