netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Horia Geantă" <horia.geanta@freescale.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	<netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
	Paul Wouters <pwouters@redhat.com>,
	"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>
Subject: Re: CCM/GCM implementation defect
Date: Thu, 23 Apr 2015 12:03:38 +0300	[thread overview]
Message-ID: <5538B56A.7060707@freescale.com> (raw)
In-Reply-To: <20150423032619.GA17648@gondor.apana.org.au>

On 4/23/2015 6:26 AM, Herbert Xu wrote:
> Hi:
>
> It looks like our IPsec implementations of CCM and GCM are buggy
This applies also to GMAC (rfc4543), right?

> in that they don't include the IV in the authentication calculation.
>
> This definitely breaks interoperability with anyone who implements
> them correctly.  The fact that there have been no reports on this
> probably means that nobody has run into this in the field yet.
Does this mean that even the test vectors (crypto/testmgr.h) are broken?

Thanks,
Horia

  parent reply	other threads:[~2015-04-23  9:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23  3:26 CCM/GCM implementation defect Herbert Xu
2015-04-23  3:36 ` David Miller
2015-04-23  9:03 ` Horia Geantă [this message]
2015-04-23  9:05   ` Herbert Xu
2015-04-23  9:58     ` Martin Willi
2015-04-23 10:01       ` Herbert Xu
2015-04-23 11:45 ` Steffen Klassert
2015-04-23 13:24   ` Martin Willi
2015-04-23 23:12     ` Herbert Xu
2015-04-24  5:30     ` Herbert Xu
2015-04-24  5:35       ` Herbert Xu
2015-04-23 15:21   ` Paul Wouters
2015-04-23 23:17   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5538B56A.7060707@freescale.com \
    --to=horia.geanta@freescale.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pwouters@redhat.com \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).