From: Jonathan Toppins <jtoppins@cumulusnetworks.com>
To: jeffrey.t.kirsher@intel.com
Cc: jesse.brandeburg@intel.com, shannon.nelson@intel.com,
carolyn.wyborny@intel.com, donald.c.skidmore@intel.com,
matthew.vick@intel.com, john.ronciak@intel.com,
mitch.a.williams@intel.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, gospo@cumulusnetworks.com,
shm@cumulusnetworks.com
Subject: Re: [PATCH v1 net-next 1/3] igb: set driver data for device entries that were missing
Date: Mon, 27 Apr 2015 11:42:29 -0400 [thread overview]
Message-ID: <553E58E5.9000105@cumulusnetworks.com> (raw)
In-Reply-To: <1428707018-6405-1-git-send-email-jtoppins@cumulusnetworks.com>
On 4/10/15 7:03 PM, Jonathan Toppins wrote:
> Three of the supported PCI device entries neglected to set driver data
> to "board_82575". This is not a problem until a new board type is
> defined, so avoid the potential problem all together.
>
> Signed-off-by: Jonathan Toppins <jtoppins@cumulusnetworks.com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index 8457d03..bb467bb 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -73,9 +73,9 @@ static const struct e1000_info *igb_info_tbl[] = {
> };
>
> static const struct pci_device_id igb_pci_tbl[] = {
> - { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_1GBPS) },
> - { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_SGMII) },
> - { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_2_5GBPS) },
> + { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_1GBPS), board_82575 },
> + { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_SGMII), board_82575 },
> + { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_2_5GBPS), board_82575 },
> { PCI_VDEVICE(INTEL, E1000_DEV_ID_I211_COPPER), board_82575 },
> { PCI_VDEVICE(INTEL, E1000_DEV_ID_I210_COPPER), board_82575 },
> { PCI_VDEVICE(INTEL, E1000_DEV_ID_I210_FIBER), board_82575 },
>
Simple keepalive to make sure these have not been forgotten, the
patchworks entries are still in "new" state.
http://patchwork.ozlabs.org/patch/460268/
http://patchwork.ozlabs.org/patch/460270/
http://patchwork.ozlabs.org/patch/460269/
Regards,
-Jon
next prev parent reply other threads:[~2015-04-27 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 23:03 [PATCH v1 net-next 1/3] igb: set driver data for device entries that were missing Jonathan Toppins
2015-04-10 23:03 ` [PATCH v1 net-next 2/3] igb: move initialization of link properties before igb_sw_init Jonathan Toppins
2015-04-28 3:20 ` Brown, Aaron F
2015-04-10 23:03 ` [PATCH v1 net-next 3/3] igb: add PHY support for Broadcom 54616 Jonathan Toppins
2015-04-28 3:22 ` Brown, Aaron F
2015-04-27 15:42 ` Jonathan Toppins [this message]
2015-04-28 3:17 ` [PATCH v1 net-next 1/3] igb: set driver data for device entries that were missing Brown, Aaron F
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E58E5.9000105@cumulusnetworks.com \
--to=jtoppins@cumulusnetworks.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=gospo@cumulusnetworks.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=matthew.vick@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@intel.com \
--cc=shm@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).