netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: David Miller <davem@davemloft.net>, ebiederm@xmission.com
Cc: netdev@vger.kernel.org, linux@roeck-us.net, stable@vger.kernel.org
Subject: Re: v3.12-stable-queue build errors
Date: Mon, 27 Apr 2015 20:00:06 +0200	[thread overview]
Message-ID: <553E7926.7040108@suse.cz> (raw)
In-Reply-To: <20150427.122528.2203423133753350979.davem@davemloft.net>

On 04/27/2015, 06:25 PM, David Miller wrote:
> From: ebiederm@xmission.com (Eric W. Biederman)
> Date: Mon, 27 Apr 2015 10:35:51 -0500
> 
>> Jiri Slaby <jslaby@suse.cz> writes:
>>
>>> On 04/25/2015, 04:16 PM, Guenter Roeck wrote:
>>>> Several powerpc build fail with:
>>>>
>>>> drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit':
>>>> drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of
>>>> function 'dev_consume_skb_any' [-Werror=implicit-function-declaration]
>>>>    dev_consume_skb_any(skb);
>>>>
>>>> dev_consume_skb_any() does not exist in 3.12.
>>>>
>>>> Introduced by 'gianfar: Carefully free skbs in functions called by netpoll'.
>>>
>>> Eric, David,
>>>
>>> what action should I take here?
>>>
>>> 1) take also:
>>> commit e6247027e5173c00efb2084d688d06ff835bc3b0
>>> Author: Eric Dumazet <edumazet@google.com>
>>> Date:   Thu Dec 5 04:45:08 2013 -0800
>>>
>>>     net: introduce dev_consume_skb_any()
>>>
>>>
>>> 2) drop 'gianfar: Carefully free skbs in functions called by netpoll'
>>> from stable-3.12
>>
>> This is probably the most reasonable.   KISS.
> 
> Yeah just drop the patch.
> 
> I didn't even want to submit this series in the first place but
> people kept poking me endlessly about it.

Now dropped. Thanks.

-- 
js
suse labs

      reply	other threads:[~2015-04-27 18:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150425141609.GA1147@roeck-us.net>
2015-04-27  8:45 ` v3.12-stable-queue build errors Jiri Slaby
2015-04-27 15:35   ` Eric W. Biederman
2015-04-27 16:17     ` Guenter Roeck
2015-04-27 16:25     ` David Miller
2015-04-27 18:00       ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553E7926.7040108@suse.cz \
    --to=jslaby@suse.cz \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=linux@roeck-us.net \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).