* Re: v3.12-stable-queue build errors [not found] <20150425141609.GA1147@roeck-us.net> @ 2015-04-27 8:45 ` Jiri Slaby 2015-04-27 15:35 ` Eric W. Biederman 0 siblings, 1 reply; 5+ messages in thread From: Jiri Slaby @ 2015-04-27 8:45 UTC (permalink / raw) To: David Miller, Eric W. Biederman, ML netdev; +Cc: Guenter Roeck, stable On 04/25/2015, 04:16 PM, Guenter Roeck wrote: > Several powerpc build fail with: > > drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit': > drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of > function 'dev_consume_skb_any' [-Werror=implicit-function-declaration] > dev_consume_skb_any(skb); > > dev_consume_skb_any() does not exist in 3.12. > > Introduced by 'gianfar: Carefully free skbs in functions called by netpoll'. Eric, David, what action should I take here? 1) take also: commit e6247027e5173c00efb2084d688d06ff835bc3b0 Author: Eric Dumazet <edumazet@google.com> Date: Thu Dec 5 04:45:08 2013 -0800 net: introduce dev_consume_skb_any() 2) drop 'gianfar: Carefully free skbs in functions called by netpoll' from stable-3.12 3) any other idea? thanks, -- js suse labs ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: v3.12-stable-queue build errors 2015-04-27 8:45 ` v3.12-stable-queue build errors Jiri Slaby @ 2015-04-27 15:35 ` Eric W. Biederman 2015-04-27 16:17 ` Guenter Roeck 2015-04-27 16:25 ` David Miller 0 siblings, 2 replies; 5+ messages in thread From: Eric W. Biederman @ 2015-04-27 15:35 UTC (permalink / raw) To: Jiri Slaby; +Cc: David Miller, ML netdev, Guenter Roeck, stable Jiri Slaby <jslaby@suse.cz> writes: > On 04/25/2015, 04:16 PM, Guenter Roeck wrote: >> Several powerpc build fail with: >> >> drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit': >> drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of >> function 'dev_consume_skb_any' [-Werror=implicit-function-declaration] >> dev_consume_skb_any(skb); >> >> dev_consume_skb_any() does not exist in 3.12. >> >> Introduced by 'gianfar: Carefully free skbs in functions called by netpoll'. > > Eric, David, > > what action should I take here? > > 1) take also: > commit e6247027e5173c00efb2084d688d06ff835bc3b0 > Author: Eric Dumazet <edumazet@google.com> > Date: Thu Dec 5 04:45:08 2013 -0800 > > net: introduce dev_consume_skb_any() > > > 2) drop 'gianfar: Carefully free skbs in functions called by netpoll' > from stable-3.12 This is probably the most reasonable. KISS. > 3) any other idea? #define dev_consume_sky_any dev_kfree_skb_any The correctness fix is updating the code to handle any context. The consume vs kfree accouting difference is not particularly interesting. Eric ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: v3.12-stable-queue build errors 2015-04-27 15:35 ` Eric W. Biederman @ 2015-04-27 16:17 ` Guenter Roeck 2015-04-27 16:25 ` David Miller 1 sibling, 0 replies; 5+ messages in thread From: Guenter Roeck @ 2015-04-27 16:17 UTC (permalink / raw) To: Eric W. Biederman; +Cc: Jiri Slaby, David Miller, ML netdev, stable On Mon, Apr 27, 2015 at 10:35:51AM -0500, Eric W. Biederman wrote: > Jiri Slaby <jslaby@suse.cz> writes: > > > On 04/25/2015, 04:16 PM, Guenter Roeck wrote: > >> Several powerpc build fail with: > >> > >> drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit': > >> drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of > >> function 'dev_consume_skb_any' [-Werror=implicit-function-declaration] > >> dev_consume_skb_any(skb); > >> > >> dev_consume_skb_any() does not exist in 3.12. > >> > >> Introduced by 'gianfar: Carefully free skbs in functions called by netpoll'. > > > > Eric, David, > > > > what action should I take here? > > > > 1) take also: > > commit e6247027e5173c00efb2084d688d06ff835bc3b0 > > Author: Eric Dumazet <edumazet@google.com> > > Date: Thu Dec 5 04:45:08 2013 -0800 > > > > net: introduce dev_consume_skb_any() > > > > > > 2) drop 'gianfar: Carefully free skbs in functions called by netpoll' > > from stable-3.12 > > This is probably the most reasonable. KISS. > Greg dropped the patch from 3.10. Guenter ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: v3.12-stable-queue build errors 2015-04-27 15:35 ` Eric W. Biederman 2015-04-27 16:17 ` Guenter Roeck @ 2015-04-27 16:25 ` David Miller 2015-04-27 18:00 ` Jiri Slaby 1 sibling, 1 reply; 5+ messages in thread From: David Miller @ 2015-04-27 16:25 UTC (permalink / raw) To: ebiederm; +Cc: jslaby, netdev, linux, stable From: ebiederm@xmission.com (Eric W. Biederman) Date: Mon, 27 Apr 2015 10:35:51 -0500 > Jiri Slaby <jslaby@suse.cz> writes: > >> On 04/25/2015, 04:16 PM, Guenter Roeck wrote: >>> Several powerpc build fail with: >>> >>> drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit': >>> drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of >>> function 'dev_consume_skb_any' [-Werror=implicit-function-declaration] >>> dev_consume_skb_any(skb); >>> >>> dev_consume_skb_any() does not exist in 3.12. >>> >>> Introduced by 'gianfar: Carefully free skbs in functions called by netpoll'. >> >> Eric, David, >> >> what action should I take here? >> >> 1) take also: >> commit e6247027e5173c00efb2084d688d06ff835bc3b0 >> Author: Eric Dumazet <edumazet@google.com> >> Date: Thu Dec 5 04:45:08 2013 -0800 >> >> net: introduce dev_consume_skb_any() >> >> >> 2) drop 'gianfar: Carefully free skbs in functions called by netpoll' >> from stable-3.12 > > This is probably the most reasonable. KISS. Yeah just drop the patch. I didn't even want to submit this series in the first place but people kept poking me endlessly about it. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: v3.12-stable-queue build errors 2015-04-27 16:25 ` David Miller @ 2015-04-27 18:00 ` Jiri Slaby 0 siblings, 0 replies; 5+ messages in thread From: Jiri Slaby @ 2015-04-27 18:00 UTC (permalink / raw) To: David Miller, ebiederm; +Cc: netdev, linux, stable On 04/27/2015, 06:25 PM, David Miller wrote: > From: ebiederm@xmission.com (Eric W. Biederman) > Date: Mon, 27 Apr 2015 10:35:51 -0500 > >> Jiri Slaby <jslaby@suse.cz> writes: >> >>> On 04/25/2015, 04:16 PM, Guenter Roeck wrote: >>>> Several powerpc build fail with: >>>> >>>> drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit': >>>> drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of >>>> function 'dev_consume_skb_any' [-Werror=implicit-function-declaration] >>>> dev_consume_skb_any(skb); >>>> >>>> dev_consume_skb_any() does not exist in 3.12. >>>> >>>> Introduced by 'gianfar: Carefully free skbs in functions called by netpoll'. >>> >>> Eric, David, >>> >>> what action should I take here? >>> >>> 1) take also: >>> commit e6247027e5173c00efb2084d688d06ff835bc3b0 >>> Author: Eric Dumazet <edumazet@google.com> >>> Date: Thu Dec 5 04:45:08 2013 -0800 >>> >>> net: introduce dev_consume_skb_any() >>> >>> >>> 2) drop 'gianfar: Carefully free skbs in functions called by netpoll' >>> from stable-3.12 >> >> This is probably the most reasonable. KISS. > > Yeah just drop the patch. > > I didn't even want to submit this series in the first place but > people kept poking me endlessly about it. Now dropped. Thanks. -- js suse labs ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-27 18:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150425141609.GA1147@roeck-us.net>
2015-04-27 8:45 ` v3.12-stable-queue build errors Jiri Slaby
2015-04-27 15:35 ` Eric W. Biederman
2015-04-27 16:17 ` Guenter Roeck
2015-04-27 16:25 ` David Miller
2015-04-27 18:00 ` Jiri Slaby
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).