From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Amine Kherbouche <amine.kherbouche@6wind.com>,
netdev@vger.kernel.org, xeb@mail.ru, roopa@cumulusnetworks.com
Cc: equinox@diac24.net
Subject: Re: [PATCH v4 1/2] expose stack entry function
Date: Thu, 28 Sep 2017 16:11:54 +0200 [thread overview]
Message-ID: <553f7dad-3bb7-ed42-c78d-e54592f87c81@6wind.com> (raw)
In-Reply-To: <d34f8440be3e1d735c694c6899c5a8b14e9a70ea.1506590878.git.amine.kherbouche@6wind.com>
Le 28/09/2017 à 11:34, Amine Kherbouche a écrit :
> Exporting mpls_forward() function to be able to be called from elsewhere
> such as MPLSoverGRE in the next commit.
I'm nitpicking, but the commit title is too generic. What about something like
'mpls: export mpls_forward()'?
When parsing history, the user knows precisely what is done in the commit
without openning it.
Regards,
Nicolas
next prev parent reply other threads:[~2017-09-28 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 9:34 [PATCH v4 0/2] Introduce MPLS over GRE Amine Kherbouche
2017-09-28 9:34 ` [PATCH v4 1/2] expose stack entry function Amine Kherbouche
2017-09-28 14:11 ` Nicolas Dichtel [this message]
2017-09-28 15:43 ` David Miller
2017-09-28 9:34 ` [PATCH v4 2/2] ip_tunnel: add mpls over gre encapsulation Amine Kherbouche
2017-09-29 4:11 ` Tom Herbert
2017-10-04 17:03 ` Amine Kherbouche
2017-09-30 23:03 ` kbuild test robot
2017-10-01 0:17 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553f7dad-3bb7-ed42-c78d-e54592f87c81@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=amine.kherbouche@6wind.com \
--cc=equinox@diac24.net \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=xeb@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).