* [PATCH net] net/bonding: Fix code style issues in a previous commit
@ 2015-04-30 0:01 Pai
2015-04-30 9:16 ` Nikolay Aleksandrov
0 siblings, 1 reply; 2+ messages in thread
From: Pai @ 2015-04-30 0:01 UTC (permalink / raw)
To: Nikolay Aleksandrov, Jay Vosburgh, Veaceslav Falico,
Andy Gospodarek, netdev, linux-kernel, Vishwanath Pai
This fixes a few coding style issues in my previous patch:
commit e913fb279c56
("net: Fix Kernel Panic in bonding driver debugfs file: rlb_hash_table")
Signed-off-by: Vishwanath Pai <vpai@akamai.com>
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index d5fe5d5..ab3eeb1 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4543,8 +4543,8 @@ unsigned int bond_get_num_tx_queues(void)
*/
int bond_create(struct net *net, const char *name)
{
- struct net_device *bond_dev;
struct bonding *bond;
+ struct net_device *bond_dev;
struct alb_bond_info *bond_info;
int res;
@@ -4559,8 +4559,7 @@ int bond_create(struct net *net, const char *name)
return -ENOMEM;
}
- /*
- * Initialize rx_hashtbl_used_head to RLB_NULL_INDEX.
+ /* Initialize rx_hashtbl_used_head to RLB_NULL_INDEX.
* It is set to 0 by default which is wrong.
*/
bond = netdev_priv(bond_dev);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] net/bonding: Fix code style issues in a previous commit
2015-04-30 0:01 [PATCH net] net/bonding: Fix code style issues in a previous commit Pai
@ 2015-04-30 9:16 ` Nikolay Aleksandrov
0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Aleksandrov @ 2015-04-30 9:16 UTC (permalink / raw)
To: Pai, Jay Vosburgh, Veaceslav Falico, Andy Gospodarek, netdev,
linux-kernel
On 04/30/2015 02:01 AM, Pai wrote:
> This fixes a few coding style issues in my previous patch:
> commit e913fb279c56
> ("net: Fix Kernel Panic in bonding driver debugfs file: rlb_hash_table")
>
> Signed-off-by: Vishwanath Pai <vpai@akamai.com>
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index d5fe5d5..ab3eeb1 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -4543,8 +4543,8 @@ unsigned int bond_get_num_tx_queues(void)
> */
> int bond_create(struct net *net, const char *name)
> {
> - struct net_device *bond_dev;
> struct bonding *bond;
> + struct net_device *bond_dev;
> struct alb_bond_info *bond_info;
> int res;
>
> @@ -4559,8 +4559,7 @@ int bond_create(struct net *net, const char *name)
> return -ENOMEM;
> }
>
> - /*
> - * Initialize rx_hashtbl_used_head to RLB_NULL_INDEX.
> + /* Initialize rx_hashtbl_used_head to RLB_NULL_INDEX.
> * It is set to 0 by default which is wrong.
> */
> bond = netdev_priv(bond_dev);
>
Hi,
Thanks for following up on my comments, but I think Dave usually prefers
such cosmetic changes via net-next, of course that's for him to say. For
the local variable arrangement I meant longest to shortest as in reverse
pyramid:
struct alb_bond_info *bond_info;
struct net_device *bond_dev;
struct bonding *bond;
int res;
Cheers,
Nik
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-30 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-30 0:01 [PATCH net] net/bonding: Fix code style issues in a previous commit Pai
2015-04-30 9:16 ` Nikolay Aleksandrov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).