From: David Ahern <david.ahern@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: rds-devel@oss.oracle.com, netdev@vger.kernel.org,
shamir.rabinovitch@oracle.com
Subject: Re: [PATCH] net/rds: fix unaligned memory access
Date: Thu, 30 Apr 2015 10:19:21 -0600 [thread overview]
Message-ID: <55425609.8060107@oracle.com> (raw)
In-Reply-To: <20150430.114403.2012017340124788492.davem@davemloft.net>
On 4/30/15 9:44 AM, David Miller wrote:
> From: David Ahern <david.ahern@oracle.com>
> Date: Thu, 30 Apr 2015 10:27:53 -0400
>
>> @@ -183,8 +183,17 @@ void rds_ib_cm_connect_complete(struct rds_connection *conn, struct rdma_cm_even
>>
>> /* If the peer gave us the last packet it saw, process this as if
>> * we had received a regular ACK. */
>> - if (dp && dp->dp_ack_seq)
>> - rds_send_drop_acked(conn, be64_to_cpu(dp->dp_ack_seq), NULL);
>> + if (dp) {
>> + /* dp structure start is not guaranteed to be 8 bytes aligned
>> + * so on SPARC we get trap for nu-aligned access. we solve
>> + * this by using the macros for unaligned memory access
>> + */
>
> "nu-aligned" is misspelled, and Mentioning sparc specifically is completely
> inappropriate because this is not a sparc specific problem.
>
oops meant to take that out. Will fix and resubmit.
prev parent reply other threads:[~2015-04-30 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 14:27 [PATCH] net/rds: fix unaligned memory access David Ahern
2015-04-30 15:23 ` David Laight
2015-04-30 15:58 ` David Miller
2015-04-30 15:44 ` David Miller
2015-04-30 16:19 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55425609.8060107@oracle.com \
--to=david.ahern@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=shamir.rabinovitch@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).