Re: [PATCH -next] net: sched: remove TC_MUNGED bits

[Jamal Hadi Salim <jhs@mojatatu.com>]

On 04/30/15 17:16, Alexei Starovoitov wrote:
> On Thu, Apr 30, 2015 at 12:12:00PM +0200, Florian Westphal wrote:
>> Not used.
>>
>> pedit sets TC_MUNGED when packet content was altered, but all the core
>> does is unset MUNGED again and then set OK2MUNGE.
>>
>> And the latter isn't tested anywhere. So lets remove both
>> TC_MUNGED and TC_OK2MUNGE.
>>
>> Signed-off-by: Florian Westphal <fw@strlen.de>
>
> Wanted to do the same.
> iproute2 doesn't use 'munge' flag either.
>
> Acked-by: Alexei Starovoitov <ast@plumgrid.com>
>

Florian,
If you are going to take this path then fix pedit to do a pskb_expand.

I think it would be better to fix the actions that do
pskb_expand_head() and let them indicated they were munged.
The flag was intended to be an optimization where it would indicate
to the action processing a packet to not bother and just trample
on the packet if noone is referencing it.
That was the rule, unfortunately nobody paid attention and it
didnt matter because it doesnt seem there was a use case where two
actions in a graph would be editing packets one after the other).

cheers,
jamal