From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Francois Romieu <romieu@fr.zoreil.com>,
Alexander Duyck <alexander.h.duyck@redhat.com>
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
Dept-HSGLinuxNICDev@qlogic.com, sony.chacko@qlogic.com,
intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com,
davem@davemloft.net, ebiederm@xmission.com
Subject: Re: [PATCH 2/3] r8169: Use dev_kfree_skb in Tx cleanup path
Date: Fri, 01 May 2015 14:06:35 +0200 [thread overview]
Message-ID: <55436C4B.7090509@gmx.de> (raw)
In-Reply-To: <20150501093420.GA11669@electric-eye.fr.zoreil.com>
On 01.05.2015 11:34, Francois Romieu wrote:
> Alexander Duyck <alexander.h.duyck@redhat.com> :
>> This change replaces the use of either dev_kfree_skb_any or
>> dev_consume_skb_any in the Tx cleanup path of this driver with
>> dev_kfree_skb. There isn't any need for the "_any" version of these
>> functions since the NAPI cleanup context is not a hard irq context.
>
> netconsole ?
>
> __dev_kfree_skb_any contains a big "if (... || irqs_disabled())" test
> and the NAPI poll handler is called with irq disabled from
> netpoll_send_skb_on_dev.
>
Indeed. Also there have been changes from Eric Biederman not long ago,
which did just the opposite: replace dev_kfree() with dev_kfree_any()
for that reason. See
http://marc.info/?l=linux-stable-commits&m=142965098111361&w=2
[CCing Eric]
Regards,
Lino
next prev parent reply other threads:[~2015-05-01 12:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 20:58 [PATCH 0/3] Stop using dev_kfree_skb_any in NAPI Tx clean-up Alexander Duyck
2015-04-30 20:58 ` [PATCH 1/3] igb, ixgbe(vf), i40e(vf), fm10k: Use dev_kfree_skb in Tx cleanup path Alexander Duyck
2015-05-01 1:46 ` Jeff Kirsher
2015-04-30 20:58 ` [PATCH 2/3] r8169: " Alexander Duyck
2015-05-01 9:34 ` Francois Romieu
2015-05-01 12:06 ` Lino Sanfilippo [this message]
2015-05-01 12:15 ` Lino Sanfilippo
2015-05-01 15:36 ` David Miller
2015-04-30 20:58 ` [PATCH 3/3] bnx2: " Alexander Duyck
2015-05-01 15:42 ` [PATCH 0/3] Stop using dev_kfree_skb_any in NAPI Tx clean-up David Miller
2015-05-01 16:45 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55436C4B.7090509@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=Dept-HSGLinuxNICDev@qlogic.com \
--cc=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).