From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH -next] net: sched: remove TC_MUNGED bits
Date: Fri, 01 May 2015 08:15:55 -0400 [thread overview]
Message-ID: <55436E7B.80800@mojatatu.com> (raw)
In-Reply-To: <20150501094619.GA22481@breakpoint.cc>
Hi Florian,
On 05/01/15 05:46, Florian Westphal wrote:
> Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>> On 04/30/15 17:16, Alexei Starovoitov wrote:
>>> On Thu, Apr 30, 2015 at 12:12:00PM +0200, Florian Westphal wrote:
>>>> Not used.
>>>>
>>>> pedit sets TC_MUNGED when packet content was altered, but all the core
>>>> does is unset MUNGED again and then set OK2MUNGE.
>>>>
>>>> And the latter isn't tested anywhere. So lets remove both
>>>> TC_MUNGED and TC_OK2MUNGE.
>>>>
>>>> Signed-off-by: Florian Westphal <fw@strlen.de>
>>>
>>> Wanted to do the same.
>>> iproute2 doesn't use 'munge' flag either.
>>>
>>> Acked-by: Alexei Starovoitov <ast@plumgrid.com>
>>>
>>
>> Florian,
>> If you are going to take this path then fix pedit to do a pskb_expand.
>
> Jamal, what about this:
>
> - I'll wait for this patch to be accepted or rejected
> - same for your suggested rttl removal patch to go in
>
I am fine with what you suggest.
So here's my ack: Jamal Hadi Salim <jhs@mojatatu.com>
Acked-by:
Can you please CC me on the other patches so i can review?
cheers,
jamal
next prev parent reply other threads:[~2015-05-01 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 10:12 [PATCH -next] net: sched: remove TC_MUNGED bits Florian Westphal
2015-04-30 21:16 ` Alexei Starovoitov
2015-05-01 0:43 ` Jamal Hadi Salim
2015-05-01 9:46 ` Florian Westphal
2015-05-01 12:15 ` Jamal Hadi Salim [this message]
2015-05-01 12:55 ` Daniel Borkmann
2015-05-03 2:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55436E7B.80800@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).