Re: [PATCH net-next] switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.

[Jamal Hadi Salim <jhs@mojatatu.com>]

On 05/06/15 17:54, Sridhar Samudrala wrote:
> - introduce port fdb obj and generic switchdev_port_fdb_add/del/dump()
> - use switchdev_port_fdb_add/del/dump in rocker/team/bonding ndo ops.
> - add support for fdb obj in switchdev_port_obj_add/del/dump()
> - switch rocker to implement fdb ops via switchdev_ops
>
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
> ---



So i raised this earlier. DaveM also chimed in - but it seems still
in there.
i havent been following the discussion and i may have missed
the agreement to keep the new IDs. Could we not just have used netlink
  IDs (as opposed to a new SWITCHDEV_OBJ_PORT_FDB id)?

> +int switchdev_port_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
> +			   struct net_device *dev, const unsigned char *addr,
> +			   u16 vid, u16 nlm_flags)
> +{
> +	struct switchdev_obj obj = {
> +		.id = SWITCHDEV_OBJ_PORT_FDB,
> +		.fdb = {
> +			.addr = addr,
> +			.vid = vid,
> +		},
> +	};
> +
> +	return switchdev_port_obj_add(dev, &obj);
> +}

cheers,
jamal