* [PATCH iproute2] ss: dctcp changes
@ 2015-05-08 20:28 Eric Dumazet
2015-05-08 20:46 ` Daniel Borkmann
2015-05-11 16:17 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2015-05-08 20:28 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
From: Eric Dumazet <edumazet@google.com>
Missing space before dctcp: markers.
With dctcp, cwnd=2 is pretty common, just display cwnd value even
if cwnd has this value, it makes parsing easier.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
diff --git a/misc/ss.c b/misc/ss.c
index 46dbb39..18ac105 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -1684,7 +1684,7 @@ static void tcp_stats_print(struct tcpstat *s)
if (s->mss)
printf(" mss:%d", s->mss);
- if (s->cwnd && s->cwnd != 2)
+ if (s->cwnd)
printf(" cwnd:%d", s->cwnd);
if (s->ssthresh)
printf(" ssthresh:%d", s->ssthresh);
@@ -1692,11 +1692,11 @@ static void tcp_stats_print(struct tcpstat *s)
if (s->dctcp && s->dctcp->enabled) {
struct dctcpstat *dctcp = s->dctcp;
- printf("dctcp:(ce_state:%u,alpha:%u,ab_ecn:%u,ab_tot:%u)",
+ printf(" dctcp:(ce_state:%u,alpha:%u,ab_ecn:%u,ab_tot:%u)",
dctcp->ce_state, dctcp->alpha, dctcp->ab_ecn,
dctcp->ab_tot);
} else if (s->dctcp) {
- printf("dctcp:fallback_mode");
+ printf(" dctcp:fallback_mode");
}
if (s->send_bps)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH iproute2] ss: dctcp changes
2015-05-08 20:28 [PATCH iproute2] ss: dctcp changes Eric Dumazet
@ 2015-05-08 20:46 ` Daniel Borkmann
2015-05-11 16:17 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2015-05-08 20:46 UTC (permalink / raw)
To: Eric Dumazet, Stephen Hemminger; +Cc: netdev
On 05/08/2015 10:28 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Missing space before dctcp: markers.
>
> With dctcp, cwnd=2 is pretty common, just display cwnd value even
> if cwnd has this value, it makes parsing easier.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Thanks Eric!
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] ss: dctcp changes
2015-05-08 20:28 [PATCH iproute2] ss: dctcp changes Eric Dumazet
2015-05-08 20:46 ` Daniel Borkmann
@ 2015-05-11 16:17 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2015-05-11 16:17 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev
On Fri, 08 May 2015 13:28:40 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Missing space before dctcp: markers.
>
> With dctcp, cwnd=2 is pretty common, just display cwnd value even
> if cwnd has this value, it makes parsing easier.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-11 16:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-08 20:28 [PATCH iproute2] ss: dctcp changes Eric Dumazet
2015-05-08 20:46 ` Daniel Borkmann
2015-05-11 16:17 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).