From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, tgraf@suug.ch
Subject: Re: [PATCH] net: Remove remaining remnants of pm_qos from netdevice.h
Date: Mon, 11 May 2015 11:27:22 -0600 [thread overview]
Message-ID: <5550E67A.4070907@gmail.com> (raw)
In-Reply-To: <20150511.132611.701878238281798138.davem@davemloft.net>
On 5/11/15 11:26 AM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Mon, 11 May 2015 13:11:06 -0400 (EDT)
>
>> From: David Ahern <dsahern@gmail.com>
>> Date: Sat, 9 May 2015 16:21:43 -0600
>>
>>> Commit e2c6544829f removed pm_qos from struct net_device but left the
>>> comment above header file. Remove those.
>>>
>>> Signed-off-by: David Ahern <dsahern@gmail.com>
>>
>> Applied, thanks David.
>
> Actually I had to revert as this breaks the build.
>
> You will need to submit another patch with this one, one that adds an
> include of <linux/pm_qos.h> to drivers/net/ethernet/intel/e1000e/e1000.h
>
> In file included from drivers/net/ethernet/intel/e1000e/82571.c:38:0:
> drivers/net/ethernet/intel/e1000e/e1000.h:346:24: error: field ‘pm_qos_req’ has incomplete type
> struct pm_qos_request pm_qos_req;
> ^
>
crap. I did a VM build with virtio only. Will redo.
David
prev parent reply other threads:[~2015-05-11 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 22:21 [PATCH] net: Remove remaining remnants of pm_qos from netdevice.h David Ahern
2015-05-11 17:11 ` David Miller
2015-05-11 17:26 ` David Miller
2015-05-11 17:27 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5550E67A.4070907@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).