* [net-next PATCH] net: Fix ifdef typo in net_device definition
@ 2015-05-11 18:31 Alexander Duyck
2015-05-11 18:39 ` Daniel Borkmann
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Duyck @ 2015-05-11 18:31 UTC (permalink / raw)
To: netdev; +Cc: davem, daniel
While trying to build for some performance testing I received the error
message below multiple times:
include/linux/netdevice.h:1658:5: warning: "CONFIG_NET_CLS_ACT" is not defined [-Wundef]
#if CONFIG_NET_CLS_ACT
It looks like this was just a typo and should have been "#ifdef" instead of
"#if".
Fixes: d2788d34885d4 ("net: sched: further simplify handle_ing")
Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
---
include/linux/netdevice.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index c4e1caf6056f..a6d706b2a947 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1655,7 +1655,7 @@ struct net_device {
rx_handler_func_t __rcu *rx_handler;
void __rcu *rx_handler_data;
-#if CONFIG_NET_CLS_ACT
+#ifdef CONFIG_NET_CLS_ACT
struct tcf_proto __rcu *ingress_cl_list;
#endif
struct netdev_queue __rcu *ingress_queue;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [net-next PATCH] net: Fix ifdef typo in net_device definition 2015-05-11 18:31 [net-next PATCH] net: Fix ifdef typo in net_device definition Alexander Duyck @ 2015-05-11 18:39 ` Daniel Borkmann 2015-05-11 19:52 ` Alexander Duyck 0 siblings, 1 reply; 3+ messages in thread From: Daniel Borkmann @ 2015-05-11 18:39 UTC (permalink / raw) To: Alexander Duyck, netdev; +Cc: davem On 05/11/2015 08:31 PM, Alexander Duyck wrote: > While trying to build for some performance testing I received the error > message below multiple times: > > include/linux/netdevice.h:1658:5: warning: "CONFIG_NET_CLS_ACT" is not defined [-Wundef] > #if CONFIG_NET_CLS_ACT > > It looks like this was just a typo and should have been "#ifdef" instead of > "#if". > > Fixes: d2788d34885d4 ("net: sched: further simplify handle_ing") > Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com> It's already here, sorry for that: https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=4cda01e86f68dacc758b2daf6e8809f2ce915b85 Best, Daniel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next PATCH] net: Fix ifdef typo in net_device definition 2015-05-11 18:39 ` Daniel Borkmann @ 2015-05-11 19:52 ` Alexander Duyck 0 siblings, 0 replies; 3+ messages in thread From: Alexander Duyck @ 2015-05-11 19:52 UTC (permalink / raw) To: Daniel Borkmann, Alexander Duyck, netdev; +Cc: davem On 05/11/2015 11:39 AM, Daniel Borkmann wrote: > On 05/11/2015 08:31 PM, Alexander Duyck wrote: >> While trying to build for some performance testing I received the error >> message below multiple times: >> >> include/linux/netdevice.h:1658:5: warning: "CONFIG_NET_CLS_ACT" is >> not defined [-Wundef] >> #if CONFIG_NET_CLS_ACT >> >> It looks like this was just a typo and should have been "#ifdef" >> instead of >> "#if". >> >> Fixes: d2788d34885d4 ("net: sched: further simplify handle_ing") >> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com> > > It's already here, sorry for that: > > https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=4cda01e86f68dacc758b2daf6e8809f2ce915b85 > > Best, > Daniel No problem. Just as long as it is fixed I am happy since it is one less patch to carry in my tree. - Alex ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-11 19:52 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-05-11 18:31 [net-next PATCH] net: Fix ifdef typo in net_device definition Alexander Duyck 2015-05-11 18:39 ` Daniel Borkmann 2015-05-11 19:52 ` Alexander Duyck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).