netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Bert Vermeulen <bert@biot.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, jogo@openwrt.org
Subject: Re: [PATCH net-next 0/3] net: phy: broken turn-around support
Date: Tue, 12 May 2015 13:56:24 -0700	[thread overview]
Message-ID: <555268F8.4030109@gmail.com> (raw)
In-Reply-To: <555265EE.9000009@biot.com>

On 12/05/15 13:43, Bert Vermeulen wrote:
> On 05/12/2015 07:33 PM, Florian Fainelli wrote:
>> Hi all,
>>
>> This is an attempt at solving the broken turn-around problem in a way that
>> is not specific to the mdio-gpio driver, since it affects different kinds of
>> platforms.
>>
>> We cannot make that localized to PHY device drivers because probing the PHY
>> device which has a broken turn-around can fail as early as in get_phy_id(),
>> therefore we need a bit of help from Device Tree/platform_data.
> 
> That is indeed a better place to put that ignore-ta flag, and the device
> tree support is of course a big improvement over the previous patch as well.
> 
> But it's still too big a hammer to hit the AR8316 problem with, I think.
> Just like the previous patch, this disables checking TA on _all_ reads, but
> I really only need it disabled on the first read.
> 
> Are you saying you've seen other systems with this TA problem? Did those
> have problems after more than just the first read?

Yes, I have a bunch of boards here that use a Broadcom BCM53125 switch
which is known not to release the line during turn-around time, and that
is for all reads. A workaround is to discard the read failure indication
from the MDIO controller, but to selectively do that, I would be keen on
using the patches I just posted.
-- 
Florian

  reply	other threads:[~2015-05-12 20:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 14:56 [PATCH] mdio-gpio: Optionally ignore TA errors Bert Vermeulen
2015-05-12 17:08 ` Florian Fainelli
2015-05-12 17:33 ` [PATCH net-next 0/3] net: phy: broken turn-around support Florian Fainelli
2015-05-12 17:33   ` [PATCH net-next 1/3] net: phy: Add phy_ignore_ta_mask to account for broken turn-around Florian Fainelli
2015-05-12 17:33   ` [PATCH net-next 2/3] of: mdio: Add a "broken-turn-around" property Florian Fainelli
2015-05-12 17:33   ` [PATCH net-next 3/3] net: phy: mdio-gpio: Handle phy_ignore_ta_mask Florian Fainelli
2015-05-13 11:17     ` Bert Vermeulen
2015-05-12 20:43   ` [PATCH net-next 0/3] net: phy: broken turn-around support Bert Vermeulen
2015-05-12 20:56     ` Florian Fainelli [this message]
2015-05-14 17:41   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555268F8.4030109@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bert@biot.com \
    --cc=davem@davemloft.net \
    --cc=jogo@openwrt.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).