From: Florian Fainelli <f.fainelli@gmail.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v1 4/7] amd-xgbe: Move the PHY support into amd-xgbe
Date: Tue, 12 May 2015 15:19:55 -0700 [thread overview]
Message-ID: <55527C8B.1040105@gmail.com> (raw)
In-Reply-To: <20150512192254.14091.4167.stgit@tlendack-t1.amdoffice.net>
On 12/05/15 12:22, Tom Lendacky wrote:
> The AMD XGBE device is intended to work with a specific integrated PHY
> and that PHY is not meant to be a standalone PHY for use by other
> devices. As such this patch removes the phylib driver and implements
> the PHY support in the amd-xgbe driver (the majority of the logic from
> the phylib driver is moved into the amd-xgbe driver).
Did not you submit a similar patch a while ago and David asked to keep
the PHY driver separate? Even though the internal PHY driver might not
be reusable on another platform, having your Ethernet driver implement a
PHY library driver seems like a potential layering issue.
--
Florian
next prev parent reply other threads:[~2015-05-12 22:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 19:22 [PATCH net-next v1 0/7] amd-xgbe: AMD XGBE driver updates 2015-05-12 Tom Lendacky
2015-05-12 19:22 ` [PATCH net-next v1 1/7] amd-xgbe: Add additional stats to be reported via ethtool Tom Lendacky
2015-05-12 19:22 ` [PATCH net-next v1 2/7] amd-xgbe: Add netif_msg_* support for driver messages Tom Lendacky
2015-05-12 19:44 ` Joe Perches
2015-05-12 20:03 ` Tom Lendacky
2015-05-12 19:22 ` [PATCH net-next v1 3/7] amd-xgbe: Rework the Rx path SKB allocation Tom Lendacky
2015-05-12 19:22 ` [PATCH net-next v1 4/7] amd-xgbe: Move the PHY support into amd-xgbe Tom Lendacky
2015-05-12 22:19 ` Florian Fainelli [this message]
2015-05-13 14:01 ` Tom Lendacky
2015-05-12 19:23 ` [PATCH net-next v1 5/7] amd-xgbe: Support defining PHY resources in ETH device node Tom Lendacky
2015-05-12 19:23 ` [PATCH net-next v1 6/7] amd-xgbe: Fix flow control setting logic Tom Lendacky
2015-05-12 19:23 ` [PATCH net-next v1 7/7] amd-xgbe: Remove manual check and set of dma_mask pointer Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55527C8B.1040105@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).