netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Jiri Pirko <jiri@resnulli.us>, roopa@cumulusnetworks.com
Cc: davem@davemloft.net, sfeldma@gmail.com,
	gospo@cumulusnetworks.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] rename RTNH_F_EXTERNAL to RTNH_F_OFFLOAD
Date: Wed, 13 May 2015 10:26:38 +0200	[thread overview]
Message-ID: <55530ABE.8040503@iogearbox.net> (raw)
In-Reply-To: <20150513054250.GA2126@nanopsycho>

On 05/13/2015 07:42 AM, Jiri Pirko wrote:
> Wed, May 13, 2015 at 07:27:10AM CEST, roopa@cumulusnetworks.com wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> RTNH_F_EXTERNAL today is printed as "offload" in iproute2 output.
>>
>> This patch renames the flag to be consistent with what the user sees.
>>
>> (I will post iproute2 patch if this gets accepted)
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>> ---
>> include/uapi/linux/rtnetlink.h |    2 +-
>> net/ipv4/fib_trie.c            |    2 +-
>> net/switchdev/switchdev.c      |    6 +++---
>> 3 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
>> index 974db03..17fb02f 100644
>> --- a/include/uapi/linux/rtnetlink.h
>> +++ b/include/uapi/linux/rtnetlink.h
>> @@ -337,7 +337,7 @@ struct rtnexthop {
>> #define RTNH_F_DEAD		1	/* Nexthop is dead (used by multipath)	*/
>> #define RTNH_F_PERVASIVE	2	/* Do recursive gateway lookup	*/
>> #define RTNH_F_ONLINK		4	/* Gateway is forced on link	*/
>> -#define RTNH_F_EXTERNAL		8	/* Route installed externally	*/
>> +#define RTNH_F_OFFLOAD		8	/* offloaded route */
>
> Since this is part of uapi, I believe this is not doable :/

You could still alias it if necessary:

   #define RTNH_F_OFFLOAD	RTNH_F_EXTERNAL

  reply	other threads:[~2015-05-13  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13  5:27 [PATCH net-next] rename RTNH_F_EXTERNAL to RTNH_F_OFFLOAD roopa
2015-05-13  5:42 ` Jiri Pirko
2015-05-13  8:26   ` Daniel Borkmann [this message]
2015-05-13 13:38     ` roopa
2015-05-13 16:13       ` David Miller
2015-05-13 19:03         ` roopa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55530ABE.8040503@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=gospo@cumulusnetworks.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).