From: Daniel Borkmann <daniel@iogearbox.net>
To: Or Gerlitz <ogerlitz@mellanox.com>, Jiri Pirko <jiri@resnulli.us>
Cc: Scott Feldman <sfeldma@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: gone with the spring cleanup..
Date: Wed, 13 May 2015 13:26:34 +0200 [thread overview]
Message-ID: <555334EA.4000404@iogearbox.net> (raw)
In-Reply-To: <55532DBD.1080901@mellanox.com>
On 05/13/2015 12:55 PM, Or Gerlitz wrote:
> On 5/13/2015 1:42 PM, Jiri Pirko wrote:
>>> Looks like the problem might be in named structures which suppose to be
>>> >anonymous. Would you try following patch:
>> oh, switchdev_obj_vlan and switchdev_obj_ipv4_fib is used in rocker..
>> So better:
>
> nope, fails.. if I remove the union (it is struct switchdev_obj has strict vlan and ipv4_fib fields) it works. Seems there's some problem also with anonymous unions.
Yes, we once had such an issue here btw:
https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/lib/test_bpf.c?id=ece80490e2c1cefda018b2e5b96d4f39083d9096
prev parent reply other threads:[~2015-05-13 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 9:12 gone with the spring cleanup Or Gerlitz
2015-05-13 10:38 ` Jiri Pirko
2015-05-13 10:42 ` Jiri Pirko
2015-05-13 10:55 ` Or Gerlitz
2015-05-13 11:26 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555334EA.4000404@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).