netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* pktgen scripts
@ 2015-05-13 13:02 Jesper Dangaard Brouer
  2015-05-13 17:14 ` Alexei Starovoitov
  0 siblings, 1 reply; 2+ messages in thread
From: Jesper Dangaard Brouer @ 2015-05-13 13:02 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann
  Cc: brouer, netdev@vger.kernel.org, Pablo Neira Ayuso, Ben Hutchings,
	Robert Olsson, Ben Greear

Hi Alexei,

I've cleaned up my pktgen scripts[1].  Do you think we should add them
instead of the sample scripts in "samples/pktgen/pktgen.conf-*" ?

The main difference is I'm replacing the "pgset" with functions not
needing global variable $PGDEV.  Three new functions reflect pktgen's
different components:
 * pg_ctrl()   control "pgctrl" (/proc/net/pktgen/pgctrl)
 * pg_thread() control the kernel threads and binding to devices
 * pg_set()    control setup of individual devices

I've named the sample scripts: "pktgen_sample{01,02,03}_desc.sh" in-order
to suggest a reading order.
I've also added a script named: "pktgen_bench_xmit_mode_netif_receive.sh"
which is basically your ingress benchmarking script.

[1] https://github.com/netoptimizer/network-testing/tree/master/pktgen
-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: pktgen scripts
  2015-05-13 13:02 pktgen scripts Jesper Dangaard Brouer
@ 2015-05-13 17:14 ` Alexei Starovoitov
  0 siblings, 0 replies; 2+ messages in thread
From: Alexei Starovoitov @ 2015-05-13 17:14 UTC (permalink / raw)
  To: Jesper Dangaard Brouer, Daniel Borkmann
  Cc: netdev@vger.kernel.org, Pablo Neira Ayuso, Ben Hutchings,
	Robert Olsson, Ben Greear

On 5/13/15 6:02 AM, Jesper Dangaard Brouer wrote:
> Hi Alexei,
>
> I've cleaned up my pktgen scripts[1].  Do you think we should add them
> instead of the sample scripts in "samples/pktgen/pktgen.conf-*" ?

+1

> The main difference is I'm replacing the "pgset" with functions not
> needing global variable $PGDEV.  Three new functions reflect pktgen's
> different components:
>   * pg_ctrl()   control "pgctrl" (/proc/net/pktgen/pgctrl)
>   * pg_thread() control the kernel threads and binding to devices
>   * pg_set()    control setup of individual devices
>
> I've named the sample scripts: "pktgen_sample{01,02,03}_desc.sh" in-order
> to suggest a reading order.
> I've also added a script named: "pktgen_bench_xmit_mode_netif_receive.sh"
> which is basically your ingress benchmarking script.
>
> [1] https://github.com/netoptimizer/network-testing/tree/master/pktgen

Looks great!! Much better than old samples/pktgen/.
Could you add a readme file as well with few command line examples?
It wasn't obvious how '-b' and other flags are working. I guess if
somebody just tries to run them, the 'usage' function will explain
things too.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-13 17:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-13 13:02 pktgen scripts Jesper Dangaard Brouer
2015-05-13 17:14 ` Alexei Starovoitov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).