From: Alexei Starovoitov <ast@plumgrid.com>
To: Daniel Borkmann <daniel@iogearbox.net>, davem@davemloft.net
Cc: fw@strlen.de, jhs@mojatatu.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: core: set and refine qdisc pkt len before tc_classify
Date: Wed, 13 May 2015 14:07:00 -0700 [thread overview]
Message-ID: <5553BCF4.601@plumgrid.com> (raw)
In-Reply-To: <1431550209-3498-1-git-send-email-daniel@iogearbox.net>
On 5/13/15 1:50 PM, Daniel Borkmann wrote:
> From: Florian Westphal <fw@strlen.de>
>
> Commit d2788d34885d4ce5ba ("net: sched: further simplify handle_ing")
> removed the call to qdisc_enqueue_root(). However, after this removal
> we no longer set qdisc pkt length, which this patch fixes. We make use
> of qdisc_pkt_len_init() from 1def9238d4aa ("net_sched: more precise
> pkt_len computation"), which was suggested as the current approach so
> far does not take into account when GRO builds up GSO packets.
>
> Fixes: d2788d34885d ("net: sched: further simplify handle_ing")
> Suggested-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> ---
Looks good as quick fix for now. Long term I still want to try to reuse
stats from underlying netdev ;)
For TX we don't have this option and have to do qdisc_pkt_len_init(),
but for RX we should be able to do something smarter.
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
next prev parent reply other threads:[~2015-05-13 21:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 20:50 [PATCH net-next v2] net: core: set and refine qdisc pkt len before tc_classify Daniel Borkmann
2015-05-13 21:07 ` Alexei Starovoitov [this message]
2015-05-13 21:20 ` Eric Dumazet
2015-05-13 21:33 ` Florian Westphal
2015-05-13 21:38 ` Eric Dumazet
2015-05-13 22:27 ` Alexei Starovoitov
2015-05-13 22:43 ` Eric Dumazet
2015-05-13 21:36 ` Daniel Borkmann
2015-05-13 21:42 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5553BCF4.601@plumgrid.com \
--to=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).