From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id Date: Mon, 18 May 2015 10:51:27 -0700 Message-ID: <555A269F.4050907@caviumnetworks.com> References: <20150516.171444.245757401088795324.davem@davemloft.net> <20150518.124152.558065488359768601.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: Aleksey Makarov , netdev , "linux-kernel@vger.kernel.org" , David Daney , "linux-pci@vger.kernel.org" , Greg Kroah-Hartman To: Bjorn Helgaas , David Miller Return-path: In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 05/18/2015 10:26 AM, Bjorn Helgaas wrote: > On Mon, May 18, 2015 at 11:41 AM, David Miller wrote: >> From: Bjorn Helgaas >> Date: Mon, 18 May 2015 11:35:20 -0500 >> >>> [+cc Greg] >>> >>> On Sat, May 16, 2015 at 4:14 PM, David Miller wrote: >>>> From: Bjorn Helgaas >>>> Date: Sat, 16 May 2015 09:49:40 -0500 >>>> >>>>> Hi Aleksey, >>>>> >>>>> On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov >>>>> wrote: >>>>>> Signed-off-by: Aleksey Makarov >>>>>> --- >>>>>> include/linux/pci_ids.h | 2 ++ >>>>>> 1 file changed, 2 insertions(+) >>>>>> >>>>>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >>>>>> index e63c02a..3633cc6 100644 >>>>>> --- a/include/linux/pci_ids.h >>>>>> +++ b/include/linux/pci_ids.h >>>>>> @@ -2327,6 +2327,8 @@ >>>>>> #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea >>>>>> #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb >>>>>> >>>>>> +#define PCI_VENDOR_ID_CAVIUM 0x177d >>>>> >>>>> Please read the note at the top of include/linux/pci_ids.h. If this >>>>> definition is used in two or more drivers, mention that in the >>>>> changelog. Otherwise, just use the bare hex value or a private >>>>> #define in your driver. >>>> >>>> It is referenced from two foo.c files in the same driver. >>>> >>>> I don't know what policy we want for situations like that. >>> >>> The current policy (1d4a433fc4e9 ("PCI: Document pci_ids.h addition >>> policy.")) predates me and I don't know the whole rationale. I can >>> see that it might reduce backporting pain for distros. >>> >>> If two foo.c files in the same driver share the PCI ID, they likely >>> share other things as well, so there's likely a shared .h file where a >>> private PCI_VENDOR_ID_CAVIUM could go. >>> >>> But this is a vendor ID (not a device ID), and it seems likely that >>> there will be other devices from Cavium, so maybe it would make sense >>> to apply the policy to device IDs, and go ahead and add vendor IDs to >>> pci_ids.h. >> >> That makes sense to me, and therefore this change is probably fine as-is. > > OK. I assume you'll take the whole series, so: > > Acked-by: Bjorn Helgaas > Thanks guys, Just for the record, the Cavium ThunderX network controller driver (that is part 2/2 of the series), is just the first user of the PCI_VENDOR_ID_CAVIUM. We have in the pipeline drivers/patches for USB (xHCI), SATA (AHCI), GPIO, I2C, MMC, and maybe others that will also be using this #define. I also agree with the concept that the vendor ID has more if a place in pci_ids.h than device IDs (which usually can go in the driver itself). David Daney