* [PATCH] mac802154: select CRYPTO when needed
@ 2015-05-19 12:18 Arnd Bergmann
2015-05-19 12:57 ` Stefan Schmidt
2015-05-19 17:39 ` Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2015-05-19 12:18 UTC (permalink / raw)
To: Alexander Aring
Cc: David S. Miller, linux-wpan, netdev, linux-kernel,
linux-arm-kernel
The mac802154 subsystem uses functions from the crypto layer and correctly
selects the individual crypto algorithms, but fails to build when the
crypto layer is disabled altogether:
crypto/built-in.o: In function `crypto_ctr_free':
:(.text+0x80): undefined reference to `crypto_drop_spawn'
crypto/built-in.o: In function `crypto_rfc3686_free':
:(.text+0xac): undefined reference to `crypto_drop_spawn'
crypto/built-in.o: In function `crypto_ctr_crypt':
:(.text+0x2f0): undefined reference to `blkcipher_walk_virt_block'
:(.text+0x2f8): undefined reference to `crypto_inc'
To solve that, this patch also selects the core crypto code,
like all other users of that code do.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Found in ARM randconfig testing
diff --git a/net/mac802154/Kconfig b/net/mac802154/Kconfig
index aa462b480a39..b355989c63b3 100644
--- a/net/mac802154/Kconfig
+++ b/net/mac802154/Kconfig
@@ -1,6 +1,7 @@
config MAC802154
tristate "Generic IEEE 802.15.4 Soft Networking Stack (mac802154)"
depends on IEEE802154
+ select CRYPTO
select CRC_CCITT
select CRYPTO_AUTHENC
select CRYPTO_CCM
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mac802154: select CRYPTO when needed
2015-05-19 12:18 [PATCH] mac802154: select CRYPTO when needed Arnd Bergmann
@ 2015-05-19 12:57 ` Stefan Schmidt
2015-05-19 17:39 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Schmidt @ 2015-05-19 12:57 UTC (permalink / raw)
To: Arnd Bergmann, Alexander Aring
Cc: David S. Miller, linux-wpan, netdev, linux-kernel,
linux-arm-kernel
Hello.
On 19/05/15 14:18, Arnd Bergmann wrote:
> The mac802154 subsystem uses functions from the crypto layer and correctly
> selects the individual crypto algorithms, but fails to build when the
> crypto layer is disabled altogether:
>
> crypto/built-in.o: In function `crypto_ctr_free':
> :(.text+0x80): undefined reference to `crypto_drop_spawn'
> crypto/built-in.o: In function `crypto_rfc3686_free':
> :(.text+0xac): undefined reference to `crypto_drop_spawn'
> crypto/built-in.o: In function `crypto_ctr_crypt':
> :(.text+0x2f0): undefined reference to `blkcipher_walk_virt_block'
> :(.text+0x2f8): undefined reference to `crypto_inc'
>
> To solve that, this patch also selects the core crypto code,
> like all other users of that code do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Found in ARM randconfig testing
>
> diff --git a/net/mac802154/Kconfig b/net/mac802154/Kconfig
> index aa462b480a39..b355989c63b3 100644
> --- a/net/mac802154/Kconfig
> +++ b/net/mac802154/Kconfig
> @@ -1,6 +1,7 @@
> config MAC802154
> tristate "Generic IEEE 802.15.4 Soft Networking Stack (mac802154)"
> depends on IEEE802154
> + select CRYPTO
> select CRC_CCITT
> select CRYPTO_AUTHENC
> select CRYPTO_CCM
Good point. I thought that would have been pulled in by CRYPTO_*
automatically. Nicely spotted.
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mac802154: select CRYPTO when needed
2015-05-19 12:18 [PATCH] mac802154: select CRYPTO when needed Arnd Bergmann
2015-05-19 12:57 ` Stefan Schmidt
@ 2015-05-19 17:39 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2015-05-19 17:39 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Alexander Aring, David S. Miller, linux-wpan, netdev,
Linux Kernel Mailing List, linux-arm-kernel
Hi Arnd,
> The mac802154 subsystem uses functions from the crypto layer and correctly
> selects the individual crypto algorithms, but fails to build when the
> crypto layer is disabled altogether:
>
> crypto/built-in.o: In function `crypto_ctr_free':
> :(.text+0x80): undefined reference to `crypto_drop_spawn'
> crypto/built-in.o: In function `crypto_rfc3686_free':
> :(.text+0xac): undefined reference to `crypto_drop_spawn'
> crypto/built-in.o: In function `crypto_ctr_crypt':
> :(.text+0x2f0): undefined reference to `blkcipher_walk_virt_block'
> :(.text+0x2f8): undefined reference to `crypto_inc'
>
> To solve that, this patch also selects the core crypto code,
> like all other users of that code do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-19 17:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-19 12:18 [PATCH] mac802154: select CRYPTO when needed Arnd Bergmann
2015-05-19 12:57 ` Stefan Schmidt
2015-05-19 17:39 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).