From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas F Herbert Subject: Re: [PATCH net-next V7 2/2] openvswitch: 802.1ad: Flow handling, actions, and vlan parsing Date: Tue, 19 May 2015 12:55:48 -0400 Message-ID: <555B6B14.5070204@gmail.com> References: <1431475596-16780-1-git-send-email-thomasfherbert@gmail.com> <1431475596-16780-3-git-send-email-thomasfherbert@gmail.com> Reply-To: thomasfherbert-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Cc: ccp-HUUA3fb44xqsTnJN9+BGXg@public.gmane.org, netdev , "dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org" , therbert-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org To: Pravin Shelar Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" List-Id: netdev.vger.kernel.org T24gNS8xNC8xNSAzOjMzIEFNLCBQcmF2aW4gU2hlbGFyIHdyb3RlOgo+IE9uIFR1ZSwgTWF5IDEy LCAyMDE1IGF0IDU6MDYgUE0sIFRob21hcyBGIEhlcmJlcnQKPiA8dGhvbWFzZmhlcmJlcnRAZ21h aWwuY29tPiB3cm90ZToKPj4gQWRkIHN1cHBvcnQgZm9yIDgwMi4xYWQgaW5jbHVkaW5nIHRoZSBh YmlsaXR5IHRvIHB1c2ggYW5kIHBvcCBkb3VibGUKPj4gdGFnZ2VkIHZsYW5zLgo+Pgo+PiBTaWdu ZWQtb2ZmLWJ5OiBUaG9tYXMgRiBIZXJiZXJ0IDx0aG9tYXNmaGVyYmVydEBnbWFpbC5jb20+Ci4u Lgo+PiArICAgICAgICAgICAgICAgaWYgKGlzX21hc2spCj4+ICsgICAgICAgICAgICAgICAgICAg ICAgIFNXX0ZMT1dfS0VZX1BVVChtYXRjaCwgZXRoLmN0Y2ksIGh0b25zKDB4ZmZmZiksCj4+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpc19tYXNrKTsKPj4gKyAgICAg ICAgICAgICAgIGVsc2UKPgo+IDgwMjFBRCBtYXNrIGZyb20gdXNlciBwYXJhbWV0ZXJzIGlzIGln bm9yZWQgYW5kIDB4ZmZmZiBpcyBzZXQuIFlvdQo+IG5lZWQgdG8gc2V0IGRlZmF1bHQgMHhmZmZm IG1hc2sgZm9yIGN0Y2kgYW5kIHRoZW4gb3ZlcnJpZGUgaXQgd2l0aAo+IHVzZXIgbWFzayBpZiBn aXZlbiBpbiB0aGUga2V5LgpQcmF2aW4sIG9uY2UgYWdhaW4sIHRoYW5rcyBmb3IgeW91ciByZXZp ZXcuCgpJIGFtIHRoaW5raW5nIHlvdSBhcmUgY29ycmVjdC4gSSBkaWQgaXQgdGhpcyB3YXkgYmVj YXVzZSBpdCBpcyB0aGUgd2F5IApzaW5nbGUgdGFnZ2VkIHZsYW5zIGFyZSBoYW5kbGVkIGluIHRo ZSBvcmlnaW5hbCB2bGFuIGNvZGUuIFdoaWNoIHJhaXNlcyAKdHdvIGlzc3Vlcy4gMS4gV2hlbiBJ IGNoYW5nZSB0aGlzLCBJIHNob3VsZCBhbHNvIGNoYW5nZSB0aGUgdGNpIGNvZGUgZm9yIApjb25z aXN0ZW5jeSBhbmQgc2hvdWxkIHRoYXQgYmUgYSBzZXBhcmF0ZSBwYXRjaD8gMi4gVGhlIGltcGxp Y2F0aW9uIGlzIAp0aGF0IHNvIGZhciBhbGwgdmxhbiB2aWQgbWFzayBtYXRjaGluZyBoYXMgYmVl biBkb25lIGluIHVzZXIgc3BhY2Ugb25seS4KPgo+PiArICAgICAgICAgICAgICAgICAgICAgICBT V19GTE9XX0tFWV9QVVQobWF0Y2gsIGV0aC5jdGNpLCBjdGNpLCBpc19tYXNrKTsKPj4gKyAgICAg ICB9Ci4uLgo+PiArewo+PiArICAgICAgIHJldHVybiBfb3ZzX3ZsYW5fZnJvbV9ubGF0dHJzKG1h dGNoLCBhdHRycywgYSwgdHJ1ZSwgbG9nKTsKPj4gK30KPj4gKwo+IEkgZG8gbm90IHNlZSB2YWx1 ZSBpbiB0aGVzZSBmdW5jdGlvbnMuIENhbiB5b3UgZGlyZWN0bHkgY2FsbAo+IF9vdnNfdmxhbl9m cm9tX25sYXR0cnMoKS4KT0sKPgo+PiAgIHN0YXRpYyBpbnQgb3ZzX2tleV9mcm9tX25sYXR0cnMo c3RydWN0IHN3X2Zsb3dfbWF0Y2ggKm1hdGNoLCB1NjQgYXR0cnMsCj4+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBubGF0dHIgKiphLCBib29sIGlzX21hc2ss Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgbG9nKQo+PiBAQCAtMTAy NCw2ICsxMDY5LDExMyBAQCBzdGF0aWMgdm9pZCBtYXNrX3NldF9ubGF0dHIoc3RydWN0IG5sYXR0 ciAqYXR0ciwgdTggdmFsKQo+PiAgICAgICAgICBubGF0dHJfc2V0KGF0dHIsIHZhbCwgb3ZzX2tl eV9sZW5zKTsKPj4gICB9Cj4+Cj4+ICtzdGF0aWMgaW50IF9wYXJzZV92bGFuX2Zyb21fbmxhdHRy cyhjb25zdCBzdHJ1Y3QgbmxhdHRyICpubGEsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHN0cnVjdCBzd19mbG93X21hdGNoICptYXRjaCwKPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgdTY0ICprZXlfYXR0cnMsCj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBubGF0dHIgKiphLCBib29sIGlzX21hc2ss Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgbG9nKQo+PiArewo+ PiArICAgICAgIGludCBlcnI7Cj4+ICsgICAgICAgX19iZTE2IHRjaTsKPj4gKwo+PiArICAgICAg IGlmICghaXNfbWFzaykgewo+PiArICAgICAgICAgICAgICAgdTY0IHZfYXR0cnMgPSAwOwo+PiAr Cj4+ICsgICAgICAgICAgICAgICB0Y2kgPSBubGFfZ2V0X2JlMTYoYVtPVlNfS0VZX0FUVFJfVkxB Tl0pOwo+PiArCj4+ICsgICAgICAgICAgICAgICBpZiAodGNpICYgaHRvbnMoVkxBTl9UQUdfUFJF U0VOVCkpIHsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgaWYgKHVubGlrZWx5KChubGFfZ2V0 X2JlMTYoYVtPVlNfS0VZX0FUVFJfRVRIRVJUWVBFXSkgPT0KPj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBodG9ucyhFVEhfUF84MDIxQUQpKSkpIHsKPj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBlcnIgPSBwYXJzZV9mbG93X25sYXR0cnMobmxhLCBhLCAm dl9hdHRycywgbG9nKTsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoZXJy KQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGVycjsK Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAodl9hdHRycykgewo+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXJyID0gb3ZzX3ZsYW5fZnJvbV9u bGF0dHJzKG1hdGNoLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZfYXR0cnMsIGEsCj4+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbG9n KTsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChlcnIpCj4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBl cnI7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfQo+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIC8qIEluc3VyZSB0aGF0IHRjaSBrZXkgYXR0cmlidXRlIGlzbid0 Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICogb3ZlcndyaXR0ZW4gYnkgZW5j YXBzdWxhdGVkIGN1c3RvbWVyIHRjaS4KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKi8KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2X2F0dHJzICY9IH4oMSA8 PCBPVlNfS0VZX0FUVFJfVkxBTik7Cj4KPiBXZSBhbHNvIG5lZWQgdG8gY2xlYXIgdl9hdHRycyB3 aGVuIGtleSBoYXMgc2luZ2xlIHZsYW4gdGFnIHdoaWNoIGlzCj4gZWxzZSBwYXJ0IG9mIHRoaXMg YmxvY2suClRoaXMgY29kZSBpcyBpbXBsZW1lbnRlZCB0aGlzIHdheSBiZWNhdXNlIEkgaGF2ZSBi ZWVuIHVzaW5nIG9ubHkgYSAKc2luZ2xlIGVuY2Fwc3VsYXRpb24gbGV2ZWwgZm9yIGRvdWJsZSB0 YWdnZWQgdmxhbnMuIEkgc25lYWsgdGhlIGlubmVyIAp0YWcgaW50byB0aGUgZW5jYXAgYW5kIGFu ZCB0aGVuIGNsZWFyIGl0IGhlcmUgYmVjYXVzZSB0aGUgZmxvdyBrZXkgaGFzIApvbmx5IG9uZSBh dHRyaWJ1dGUgdHlwZSBmb3IgdmxhbiBhbmQgdl9hdHRycyBpcyBvbmx5IHVzZWQgaW5zaWRlIHRo ZSAKZW5jYXBzdWxhdGlvbi4KQWxvbmcgd2l0aCB0aGlzIGNoYW5nZSwgSSBjYW4gYWxzbyB1cGRh dGUgCkRvY3VtZW50YXRpb24vbmV0d29ya2luZy9vcGVudnN3aXRjaC50eHQgdG8gc2hvdyB0aGUg ZG91YmxlIG5lc3RlZCAKZW5jYXBzdWxhdGlvbiBmbG93IGtleS4KPgo+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICprZXlfYXR0cnMgfD0gdl9hdHRyczsKPj4gKyAgICAgICAgICAg ICAgICAgICAgICAgfSBlbHNlIHsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBl cnIgPSBwYXJzZV9mbG93X25sYXR0cnMobmxhLCBhLCBrZXlfYXR0cnMsCj4+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxvZyk7Cj4+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGVycikKPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBlcnI7Cj4+ICsgICAgICAgICAgICAgICAg ICAgICAgIH0KPj4gKyAgICAgICAgICAgICAgIH0gZWxzZSBpZiAoIXRjaSkgewo+PiArICAgICAg ICAgICAgICAgICAgICAgICAvKiBDb3JuZXIgY2FzZSBmb3IgdHJ1bmNhdGVkIDgwMi4xUSBoZWFk ZXIuICovCj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGlmIChubGFfbGVuKG5sYSkpIHsKPj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBPVlNfTkxFUlIobG9nLCAiVHJ1bmNhdGVk IDgwMi4xUSBoZWFkZXIgaGFzIG5vbi16ZXJvIGVuY2FwIGF0dHJpYnV0ZS4iKTsKPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPj4gKyAgICAgICAgICAg ICAgICAgICAgICAgfQo+PiArICAgICAgICAgICAgICAgfSBlbHNlIHsKPj4gKyAgICAgICAgICAg ICAgICAgICAgICAgT1ZTX05MRVJSKGxvZywgIkVuY2FwIGF0dHIgaXMgc2V0IGZvciBub24tVkxB TiBmcmFtZSIpOwo+PiArICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gIC1FSU5WQUw7Cj4+ ICsgICAgICAgICAgICAgICB9Cj4+ICsKPiBGb3IgZG91YmxlIHZsYW4gdGFnIGNhc2Ugd2UgbmVl ZCB0byBoYXZlIGRvdWJsZSBlbmNhcCBhdHRyaWJ1dGVzIGluCj4gZmxvdyBrZXk7IG9uZSBmb3Ig ZWFjaCB0YWcuIFNvIGZsb3cga2V5IHNob3VsZCBsb29rIGxpa2U6Cj4KPiBldGhfdHlwZSgweDg4 QTgpLHZsYW4odmlkPTEwKSxlbmNhcChldGhfdHlwZSgweDA4MTAwKSwgdmxhbih2aWQ9MjApLAo+ IGVuY2FwKGV0aF90eXBlKDB4MDgwMCksIC4uLikpCj4KPiBDYW4geW91IGFkanVzdCB2bGFuIHBh cnNpbmcgY29kZSBhY2NvcmRpbmcgPwpZZXMsIEkgdGhpbmsgeW91IGFyZSByaWdodC4gSSBzaG91 bGQgY2hhbmdlIHRoZSBjb2RlIHRvIHVzZSB0d28gbGV2ZWxzIApvZiBlbmNhcHN1bGF0aW9uIGZv ciBkb3VibGUgdGFnZ2VkIHZsYW5zLiBUaGlzIGFsc28gd291bGQgYmUgdGhlIGJlc3QgCmZvciBj b25zaXN0ZW5jeSB3aXRoIGZ1dHVyZSBpbXBsZW1lbnRhdGlvbiBvZiA4MDIuMWFoLgo+Cj4KLi4u Cj4+ICt7Cj4+ICsgICAgICAgcmV0dXJuIF9wYXJzZV92bGFuX2Zyb21fbmxhdHRycyhubGEsIG1h dGNoLCBrZXlfYXR0cnMsIGEsIGZhbHNlLCBsb2cpOwo+PiArfQo+IFlvdSBjYW4gbW92ZSB0aGUg a2V5IHBhcnNpbmcgYmxvY2sgZnJvbSBfcGFyc2Vfdmxhbl9mcm9tX25sYXR0cnMoKQo+IGhlcmUg YW5kIG1vdmUgbWFzayBibG9jayBpbiBmdW5jdGlvbiBiZWxsb3cgYW5kIGdldCByaWRlIG9mCj4g X3BhcnNlX3ZsYW5fZnJvbV9ubGF0dHJzKCkgZnVuY3Rpb24uCk9LLiBJIHRoaW5rIHRoaXMgd2ls bCBtYWtlIHRoZSBjb2RlIG1vcmUgc3RyYWlnaHQgZm9yd2FyZC4KPgo+PiArCj4+ICtzdGF0aWMg aW50IHBhcnNlX3ZsYW5fbWFza19mcm9tX25sYXR0cnMoY29uc3Qgc3RydWN0IG5sYXR0ciAqbmxh LAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHN3X2Zs b3dfbWF0Y2ggKm1hdGNoLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgdTY0ICprZXlfYXR0cnMsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBjb25zdCBzdHJ1Y3QgbmxhdHRyICoqYSwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGJvb2wgbG9nKQo+PiArewo+PiArICAgICAgIHJldHVybiBfcGFyc2Vf dmxhbl9mcm9tX25sYXR0cnMobmxhLCBtYXRjaCwga2V5X2F0dHJzLCBhLCB0cnVlLCBsb2cpOwo+ PiArfQo+PiArCj4+ICAgLyoqCgoKLS0gClRob21hcyBGLiBIZXJiZXJ0Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldiBtYWlsaW5nIGxpc3QKZGV2QG9w ZW52c3dpdGNoLm9yZwpodHRwOi8vb3BlbnZzd2l0Y2gub3JnL21haWxtYW4vbGlzdGluZm8vZGV2 Cg==