[PATCH] vxlan: correct typo in call to unregister_netdevice_queue

[PATCH] vxlan: correct typo in call to unregister_netdevice_queue

[John W. Linville]

By inspection, this appears to be a typo.  The gating comparison
involves vxlan->dev rather than dev.  In fact, dev is the iterator in
the preceding loop above but it is actually constant in the 2nd loop.

Use of dev seems to be a bad cut-n-paste from the prior call to
unregister_netdevice_queue.  Change dev to vxlan->dev, since that is
what is actually being checked.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
 drivers/net/vxlan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 27a5f954f8e9..21a0fbf1ed94 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -2961,7 +2961,7 @@ static void __net_exit vxlan_exit_net(struct net *net)
 		 * to the list by the previous loop.
 		 */
 		if (!net_eq(dev_net(vxlan->dev), net))
-			unregister_netdevice_queue(dev, &list);
+			unregister_netdevice_queue(vxlan->dev, &list);
 	}
 
 	unregister_netdevice_many(&list);
-- 
2.1.0

Re: [PATCH] vxlan: correct typo in call to unregister_netdevice_queue

[David Miller]

From: "John W. Linville" <linville@tuxdriver.com>
Date: Mon, 18 May 2015 13:51:24 -0400

> By inspection, this appears to be a typo.  The gating comparison
> involves vxlan->dev rather than dev.  In fact, dev is the iterator in
> the preceding loop above but it is actually constant in the 2nd loop.
> 
> Use of dev seems to be a bad cut-n-paste from the prior call to
> unregister_netdevice_queue.  Change dev to vxlan->dev, since that is
> what is actually being checked.
> 
> Signed-off-by: John W. Linville <linville@tuxdriver.com>

Indeed, your fix looks correct to me.

Applied, thanks John.

Re: [PATCH] vxlan: correct typo in call to unregister_netdevice_queue

[Nicolas Dichtel]

Le 18/05/2015 22:59, David Miller a écrit :
> From: "John W. Linville" <linville@tuxdriver.com>
> Date: Mon, 18 May 2015 13:51:24 -0400
>
>> By inspection, this appears to be a typo.  The gating comparison
>> involves vxlan->dev rather than dev.  In fact, dev is the iterator in
>> the preceding loop above but it is actually constant in the 2nd loop.
>>
>> Use of dev seems to be a bad cut-n-paste from the prior call to
>> unregister_netdevice_queue.  Change dev to vxlan->dev, since that is
>> what is actually being checked.
>>
>> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> Indeed, your fix looks correct to me.
>
> Applied, thanks John.
>
I was off the last couple of days. But I agree with that patch.
FWIW:
Fixes: f01ec1c017de ("vxlan: add x-netns support")