From: Mark Salyzyn <salyzyn@android.com>
To: Hannes Frederic Sowa <hannes@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Al Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Ying Xue <ying.xue@windriver.com>, Christoph Hellwig <hch@lst.de>,
netdev@vger.kernel.org
Subject: Re: net/unix: sk_socket can disappear when state is unlocked
Date: Fri, 22 May 2015 09:24:27 -0700 [thread overview]
Message-ID: <555F583B.1010309@android.com> (raw)
In-Reply-To: <1432308915.28081.10.camel@redhat.com>
On 05/22/2015 08:35 AM, Hannes Frederic Sowa wrote:
> I still wonder if we need to actually recheck the condition and not
> simply break out of unix_stream_data_wait:
>
> We return to the unix_stream_recvmsg loop and recheck the
> sk_receive_queue. At this point sk_receive_queue is not really protected
> with unix_state_lock against concurrent modification with unix_release,
> as such we could end up concurrently dequeueing packets if socket is
> DEAD.
sock destroy(sic) is called before sock_orphan which sets SOCK_DEAD, so
the receive queue has already been drained.
Sincerely -- Mark Salyzyn
next prev parent reply other threads:[~2015-05-22 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 16:25 net/unix: sk_socket can disappear when state is unlocked Mark Salyzyn
2015-05-22 9:50 ` Hannes Frederic Sowa
2015-05-22 14:51 ` Mark Salyzyn
2015-05-22 15:35 ` Hannes Frederic Sowa
2015-05-22 16:24 ` Mark Salyzyn [this message]
2015-05-22 18:16 ` Hannes Frederic Sowa
2015-05-22 19:59 ` Mark Salyzyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555F583B.1010309@android.com \
--to=salyzyn@android.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=hannes@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).