Re: [PATCH] sched: Avoid NULL pointer in the function, qdisc_get_rtab

[Jamal Hadi Salim <jhs@mojatatu.com>]

On 05/26/15 05:31, Jamal Hadi Salim wrote:
> On 05/22/15 13:33, Nicholas Krause wrote:
>
>>
>> diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
>> index ad9eed7..44a8995 100644
>> --- a/net/sched/sch_api.c
>> +++ b/net/sched/sch_api.c
>> @@ -400,7 +400,7 @@ struct qdisc_rate_table *qdisc_get_rtab(struct
>> tc_ratespec *r, struct nlattr *ta
>>       }
>>
>>       rtab = kmalloc(sizeof(*rtab), GFP_KERNEL);
>> -    if (rtab) {
>> +    if (!rtab) {
>>           rtab->rate = *r;
>>           rtab->refcnt = 1;
>>           memcpy(rtab->data, nla_data(tab), 1024);
>>
>
> Did i miss something so clever it is not obvious? ;->
> If rtab's kmalloc fails  you want to set rtab's fields?
> And what is wrong with returning a null rtab again?
>

Yikes. Seems i fell for some trolling. Hasnt happened since
summer of 94. You got me ;->

cheers,
jamal