netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: <netdev@vger.kernel.org>
Cc: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] amd-xgbe-phy: Fix initial mode when autoneg is disabled
Date: Tue, 26 May 2015 09:57:33 -0500	[thread overview]
Message-ID: <556489DD.3070002@amd.com> (raw)
In-Reply-To: <20150526145149.29899.24836.stgit@tlendack-t1.amdoffice.net>

On 05/26/2015 09:51 AM, Tom Lendacky wrote:
> When the ethtool command is used to set the speed of the device while
> the device is down, the check to set the initial mode may fail when
> the device is brought up, causing failure to bring the device up.
>
> Update the code to set the initial mode based on the desired speed if
> auto-negotiation is disabled.
>
> This patch fixes a bug introduced by:
> d9663c8c2149 ("amd-xgbe-phy: Use phydev advertising field vs supported")
>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>   drivers/net/phy/amd-xgbe-phy.c |   45 +++++++++++++++++++++++++++++++++++++---
>   1 file changed, 42 insertions(+), 3 deletions(-)
>

Hi David,

Just a heads up on this patch. With the removal of this file in net-next
you'll have a conflict when merging into net-next. My updates from the
other day to net-next fix this bug in the new file/location.

Thanks,
Tom

  reply	other threads:[~2015-05-26 14:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 14:51 [PATCH net] amd-xgbe-phy: Fix initial mode when autoneg is disabled Tom Lendacky
2015-05-26 14:57 ` Tom Lendacky [this message]
2015-05-26 23:48   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556489DD.3070002@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).