netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wang Long <long.wanglong@huawei.com>,
	davem@davemloft.net, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, peifeiyue@huawei.com,
	wanglong@laoqinren.net
Subject: Re: [PATCH] netevent: remove automatic variable in register_netevent_notifier()
Date: Thu, 28 May 2015 17:07:53 +0300	[thread overview]
Message-ID: <55672139.1050306@cogentembedded.com> (raw)
In-Reply-To: <1432807250-223365-1-git-send-email-long.wanglong@huawei.com>

Hello.

On 5/28/2015 1:00 PM, Wang Long wrote:

> Remove automatic variable 'err' in register_netevent_notifier() and
> return the return value of atomic_notifier_chain_register() directly.

    s/return value/result/, in order to avoid tautology.

> Signed-off-by: Wang Long <long.wanglong@huawei.com>
[...]

WBR, Sergei

  reply	other threads:[~2015-05-28 14:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28 10:00 [PATCH] netevent: remove automatic variable in register_netevent_notifier() Wang Long
2015-05-28 14:07 ` Sergei Shtylyov [this message]
2015-05-29  0:56   ` long.wanglong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55672139.1050306@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=long.wanglong@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=peifeiyue@huawei.com \
    --cc=wanglong@laoqinren.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).