From: David Vrabel <david.vrabel@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>, <xen-devel@lists.xen.org>,
<netdev@vger.kernel.org>
Cc: <wei.liu2@citrix.com>
Subject: Re: [PATCH net] xen: netback: read hotplug script once at start of day.
Date: Fri, 29 May 2015 17:28:42 +0100 [thread overview]
Message-ID: <556893BA.9030300@citrix.com> (raw)
In-Reply-To: <1432916693-21121-1-git-send-email-ian.campbell@citrix.com>
On 29/05/15 17:24, Ian Campbell wrote:
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -235,6 +235,7 @@ static int netback_remove(struct xenbus_device *dev)
> kobject_uevent(&dev->dev.kobj, KOBJ_OFFLINE);
> xen_unregister_watchers(be->vif);
> xenbus_rm(XBT_NIL, dev->nodename, "hotplug-status");
> + kfree(be->vif->hotplug_script);
Should this kfree() be in xenvif_free()?
> xenvif_free(be->vif);
> be->vif = NULL;
> }
David
next prev parent reply other threads:[~2015-05-29 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 16:24 [PATCH net] xen: netback: read hotplug script once at start of day Ian Campbell
2015-05-29 16:28 ` David Vrabel [this message]
2015-05-29 17:38 ` Wei Liu
2015-06-01 8:52 ` Ian Campbell
2015-06-01 9:07 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556893BA.9030300@citrix.com \
--to=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).